From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64031 invoked by alias); 1 Mar 2016 14:55:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64003 invoked by uid 89); 1 Mar 2016 14:55:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=infos, H*MI:sk:2016030 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 01 Mar 2016 14:55:52 +0000 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Mar 2016 14:55:49 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 1 Mar 2016 14:55:35 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: krebbel@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9307A1B08061 for ; Tue, 1 Mar 2016 14:55:57 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u21EtZbV6357468 for ; Tue, 1 Mar 2016 14:55:35 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u21EtYLw006912 for ; Tue, 1 Mar 2016 07:55:35 -0700 Received: from [9.152.212.123] (dyn-9-152-212-123.boeblingen.de.ibm.com [9.152.212.123]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u21EtY0d006878; Tue, 1 Mar 2016 07:55:34 -0700 Subject: Re: [PATCH 1/9] gensupport: Fix define_subst operand renumbering. To: James Greenhalgh References: <1456735599-21355-1-git-send-email-krebbel@linux.vnet.ibm.com> <1456735599-21355-2-git-send-email-krebbel@linux.vnet.ibm.com> <56D4497A.40304@redhat.com> <56D560F8.40500@linux.vnet.ibm.com> <20160301121500.GA7234@arm.com> <56D58C86.7020404@linux.vnet.ibm.com> <20160301133822.GA19657@arm.com> Cc: Bernd Schmidt , gcc-patches@gcc.gnu.org, uweigand@de.ibm.com From: Andreas Krebbel Message-ID: <56D5AD66.20706@linux.vnet.ibm.com> Date: Tue, 01 Mar 2016 14:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160301133822.GA19657@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16030114-0013-0000-0000-000008D39DC1 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00039.txt.bz2 On 03/01/2016 02:38 PM, James Greenhalgh wrote: > On Tue, Mar 01, 2016 at 01:35:18PM +0100, Andreas Krebbel wrote: >> On 03/01/2016 01:15 PM, James Greenhalgh wrote: >>> On Tue, Mar 01, 2016 at 10:29:28AM +0100, Andreas Krebbel wrote: >>>> On 02/29/2016 02:36 PM, Bernd Schmidt wrote: >>>>> On 02/29/2016 09:46 AM, Andreas Krebbel wrote: >>>>>> Ok for mainline? >>>>>> >>>>>> * gensupport.c (process_substs_on_one_elem): Split loop to >>>>>> complete mark_operands_used_in_match_dup on all expressions in the >>>>>> vector first. >>>>>> (adjust_operands_numbers): Inline into process_substs_on_one_elem >>>>>> and remove function. >>>>> >>>>> Didn't I approve this a while ago? Not sure it's appropriate for stage4 >>>>> though; is this series fixing an important regression? >>>> >>>> Yes you did. I didn't commit it until the rest of the patch series was ready to commit. The patch >>>> series fixes a fundamental problem in the backend. The first iteration was posted before stage 4 but >>>> it took me a few iterations to get it right. >>>> >>>> I've committed the patch now after retesting. >>> >>> This looks like it has caused failures in the following tests on an >>> x86_64-none-linux-gnu build. >> >> I've regression tested the patch on x86_64 as well. Are there specific >> options required to enable these tests? > > The bisect robot just builds a stage one compiler, configured with: > > ./configure --disable-bootstrap, --enable-languages=c,c++,fortran > --disable-multilib --disable-libsanitizer > > My system GCC is a 5.2 from the release sources with: > > ../gcc-5.2.0/configure --with-bugurl='Good luck' > --enable-languages=c,c++,go,fortran,objc,obj-c++ > --prefix=/work/install-gcc-5.2.0 --enable-shared > --enable-linker-build-id --without-included-gettext > --enable-threads=posix --enable-nls > --enable-clocale=gnu --enable-libstdcxx-debug > --enable-libstdcxx-time=yes > --enable-gnu-unique-object --disable-libmudflap > --enable-plugin --with-system-zlib > --disable-browser-plugin --enable-java-awt=gtk > --enable-gtk-cairo --with-arch-directory=amd64 > --enable-objc-gc --enable-multiarch > --disable-werror --with-arch-32=i686 > --with-abi=m64 --with-multilib-list=m32,m64,mx32 > --with-tune=native --enable-checking=release > --build=x86_64-linux-gnu --host=x86_64-linux-gnu > --target=x86_64-linux-gnu > > I tried a full bootstrap at that revision and still see these failures. > Who knows what state has been corrupted, or that you silently get away with, > if this is an undefined behaviour somewhere :-). I haven't tried with a > valgrind checking build to see what it can spot. Ok. Thanks for the infos. I'll try to have a look. I've reverted the patch now. Bye, -Andreas-