From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-422766-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 41397 invoked by alias); 4 Mar 2016 12:53:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 41387 invoked by uid 89); 4 Mar 2016 12:53:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Cool
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Mar 2016 12:53:24 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id AA4F04C36E;	Fri,  4 Mar 2016 12:53:22 +0000 (UTC)
Received: from localhost.localdomain (vpn1-7-248.ams2.redhat.com [10.36.7.248])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u24CrLvY001821;	Fri, 4 Mar 2016 07:53:21 -0500
Subject: Re: [PATCH 2/2] PR c/68187: fix overzealous -Wmisleading-indentation (comment #1)
To: Patrick Palka <patrick@parcs.ath.cx>, David Malcolm <dmalcolm@redhat.com>
References: <1457018483-26829-1-git-send-email-dmalcolm@redhat.com> <1457018483-26829-2-git-send-email-dmalcolm@redhat.com> <CA+C-WL9w-4EUDfDUxY4RZ8Tvm5+oOiEdRk8sA0kEWCQf-xavEg@mail.gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
From: Bernd Schmidt <bschmidt@redhat.com>
Message-ID: <56D98540.30702@redhat.com>
Date: Fri, 04 Mar 2016 12:53:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CA+C-WL9w-4EUDfDUxY4RZ8Tvm5+oOiEdRk8sA0kEWCQf-xavEg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-03/txt/msg00338.txt.bz2

On 03/03/2016 06:15 PM, Patrick Palka wrote:
> Cool, this also fixes the false-positives seen in bdwgc, whose coding
> style suggests indenting things inside an #ifdef as if it were an
> if(), e.g.:
>
>      if (a)
>        foo ();
> #   ifndef A
>        bar ();
> #   endif
>      ...

Once again I find myself thinking this is not a false positive, but 
terrible code we should warn for.


Bernd