From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-422979-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 113515 invoked by alias); 9 Mar 2016 09:33:35 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 113493 invoked by uid 89); 9 Mar 2016 09:33:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=hood, appropriately, UNSUPPORTED, predefines
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Mar 2016 09:33:14 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25DF349;	Wed,  9 Mar 2016 01:32:15 -0800 (PST)
Received: from [10.2.206.200] (e100706-lin.cambridge.arm.com [10.2.206.200])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E43D23F246;	Wed,  9 Mar 2016 01:33:12 -0800 (PST)
Message-ID: <56DFEDD7.6050209@foss.arm.com>
Date: Wed, 09 Mar 2016 09:33:00 -0000
From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: GCC Patches <gcc-patches@gcc.gnu.org>
CC: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,  Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][ARM] Split out armv7ve effective target check
References: <56D6EB74.6070702@foss.arm.com>
In-Reply-To: <56D6EB74.6070702@foss.arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-03/txt/msg00551.txt.bz2

Ping.
https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00162.html

Thanks,
Kyrill
On 02/03/16 13:32, Kyrill Tkachov wrote:
> Hi all,
>
> I'm seeing the fails:
> FAIL: gcc.target/arm/atomic_loaddi_2.c scan-assembler-times ldrd\tr[0-9]+, r[0-9]+, \\[r[0-9]+\\] 1
> FAIL: gcc.target/arm/atomic_loaddi_5.c scan-assembler-times ldrd\tr[0-9]+, r[0-9]+, \\[r[0-9]+\\] 1
> FAIL: gcc.target/arm/atomic_loaddi_8.c scan-assembler-times ldrd\tr[0-9]+, r[0-9]+, \\[r[0-9]+\\] 1
>
> when testing an arm multilib with /-march=armv7-a.
>
> The tests have an effective target check for armv7ve but it doesn't work because
> under the hood the check is the same as for armv7-a, that is it checks for the __ARM_ARCH_7A__
> predefine which is set for both march values.
>
> To check for armv7ve using predefines we need to check for both __ARM_ARCH_7A__ and for the hardware
> integer division predefine, making armv7ve special.
>
> So this patch separates the effective target check definition from the rest of the architectures
> and defines it appropriately.
>
> With this patch the aforementioned tests appear UNSUPPORTED when testing the /-march=armv7-a multilib.
>
> Ok for trunk?
>
> Thanks,
> Kyrill
>
> 2016-03-02  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>     * lib/target-supports.exp: Remove v7ve entry from loop
>     creating effective target checks.
>     (check_effective_target_arm_arch_v7ve_ok): New procedure.
>     (add_options_for_arm_arch_v7ve): Likewise.