From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Martin Sebor <msebor@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
Marek Polacek <polacek@redhat.com>
Subject: Re: [PATCH] c++/67376 Comparison with pointer to past-the-end, of array fails inside constant expression
Date: Wed, 16 Mar 2016 19:38:00 -0000 [thread overview]
Message-ID: <56E9B62D.4000103@redhat.com> (raw)
In-Reply-To: <20160314221336.GR3017@tucnak.redhat.com>
On 03/14/2016 04:13 PM, Jakub Jelinek wrote:
> On Mon, Mar 14, 2016 at 03:25:07PM -0600, Martin Sebor wrote:
>> PR c++/67376 - [5/6 regression] Comparison with pointer to past-the-end
>> of array fails inside constant expression
>> PR c++/70170 - [6 regression] bogus not a constant expression error comparing
>> pointer to array to null
>> PR c++/70172 - incorrect reinterpret_cast from integer to pointer error
>> on invalid constexpr initialization
>> PR c++/60760 - arithmetic on null pointers should not be allowed in constant
>> expressions
>> PR c++/70228 - insufficient detail in diagnostics for a constexpr out of bounds
>> array subscript
>
> Can you please check up the formatting in the patch?
> Seems e.g. you've replaced tons of tabs with 8 spaces etc. (check your
> editor setting, and check the patch with contrib/check-GNU-style.sh).
> There is some trailing whitespace too, spaces before [, etc.
Jakub, do you have any comments on the substance of the patch? If so,
it would help immensely if you could provide them so that Martin could
address technical issues at the same time as he fixes up whitespace nits.
jeff
next prev parent reply other threads:[~2016-03-16 19:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 21:25 Martin Sebor
2016-03-14 22:13 ` Jakub Jelinek
2016-03-16 19:38 ` Jeff Law [this message]
2016-03-16 22:53 ` Jakub Jelinek
2016-03-16 19:53 ` Jeff Law
2016-03-17 21:35 ` Martin Sebor
2016-03-18 17:48 ` Jeff Law
2016-03-21 17:55 ` Jason Merrill
2016-03-21 22:13 ` Jeff Law
2016-03-22 19:10 ` Jason Merrill
2016-03-22 20:38 ` Martin Sebor
2016-03-23 20:41 ` Jason Merrill
2016-03-28 23:20 ` Martin Sebor
2016-03-29 19:07 ` Jason Merrill
2016-03-30 5:56 ` Martin Sebor
2016-03-30 16:02 ` Jason Merrill
2016-03-30 16:58 ` Martin Sebor
2016-03-30 20:19 ` Jason Merrill
2016-03-30 23:09 ` Martin Sebor
2016-03-31 8:48 ` Jason Merrill
2016-03-31 19:30 ` Martin Sebor
2016-03-31 20:07 ` Jason Merrill
2016-05-31 20:33 ` Martin Sebor
2016-05-31 20:48 ` Jason Merrill
2016-03-31 17:53 ` Jeff Law
2016-03-18 19:13 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9B62D.4000103@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=msebor@gmail.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).