Re: [PATCH, PR70161] Fix fdump-ipa-all-graph

[Tom de Vries <Tom_deVries@mentor.com>]

On 15/03/16 12:37, Richard Biener wrote:
> On Mon, 14 Mar 2016, Tom de Vries wrote:
>
>> Hi,
>>
>> this patch fixes PR70161, a 4.9/5/6 regression.
>>
>> Currently when using -fdump-ipa-all-graph, the compiler ICEs in
>> execute_function_dump when testing for pass->graph_dump_initialized, because
>> pass == NULL.
>>
>> The patch fixes:
>> - the ICE by setting the pass argument in the call to
>>    execute_function_dump in execute_one_ipa_transform_pass
>> - a subsequent ICE (triggered with -fipa-pta) by saving, resetting and
>>    restoring dump_file_name in cgraph_node::get_body, alongside the
>>    saving and restoring of the dump_file variable.
>> - the duplicate edges in the subsequently generated dot file by
>>    ensuring that execute_function_dump is called only once per function
>>    per pass. [ Note that this bit also has an effect for the normal dump
>>    files for the ipa passes with transform function. For those functions,
>>    atm execute_function_dump is called both after execute and after
>>    transform. With the patch, it's only called after transform. ]
>>
>> Bootstrapped and reg-tested on x86_64.
>>
>> OK for stage4?
>
> Ok.

All of the patch also OK for 4.9/5 branch?

[ The first 2 bits fix ICES. The last part fixes a duplicate edges 
problem in the dot file, I'm not sure if that's needed in the release 
branches. ]

Thanks,
- Tom