From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-423495-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 112953 invoked by alias); 18 Mar 2016 01:18:44 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 112928 invoked by uid 89); 18 Mar 2016 01:18:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=incoming
X-Spam-User: qpsmtpd, 3 recipients
X-HELO: mail.windriver.com
Received: from mail.windriver.com (HELO mail.windriver.com) (147.11.1.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 18 Mar 2016 01:18:42 +0000
Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41])	by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id u2I1IZKV002843	(version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);	Thu, 17 Mar 2016 18:18:37 -0700 (PDT)
Received: from [128.224.162.159] (128.224.162.159) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.248.2; Thu, 17 Mar 2016 18:18:34 -0700
Subject: Re: [PATCH]PR other/70268: map one directory name (old) to another (new) in __FILE__
To: Joseph Myers <joseph@codesourcery.com>
References: <1458205064-10251-1-git-send-email-hongxu.jia@windriver.com> <alpine.DEB.2.10.1603172242460.18027@digraph.polyomino.org.uk>
CC: <jakub@gcc.gnu.org>, <rguenth@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>,        <richard.purdie@linuxfoundation.org>
From: Hongxu Jia <hongxu.jia@windriver.com>
Message-ID: <56EB5766.7010109@windriver.com>
Date: Fri, 18 Mar 2016 02:30:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1603172242460.18027@digraph.polyomino.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-03/txt/msg01067.txt.bz2

On 03/18/2016 06:43 AM, Joseph Myers wrote:
> On Thu, 17 Mar 2016, Hongxu Jia wrote:
>
>> +      if (add_file_prefix_map(arg) < 0)

+      if (add_file_prefix_map (arg) < 0)


I will correct them in V3.

> Bad formatting (missing space before '(').  Likewise elsewhere in this
> patch.
>
>> +@item -ffile-prefix-map=@var{old}=@var{new}
>> +@opindex ffile-prefix-map
>> +When parsing __FILE__, __BASE_FILE__ and __builtin_FILE(), use directory
>> +@file{@var{new}} to replace @file{@var{old}}.
> Missing use of @code{} around literal source code text.

+When parsing @code{__FILE__}, @code{__BASE_FILE__} and 
@code{__builtin_FILE()}, use directory

Thanks for pointing it out. V3 incoming

//Hongxu

>