From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83410 invoked by alias); 18 Mar 2016 12:10:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83377 invoked by uid 89); 18 Mar 2016 12:10:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:931 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Mar 2016 12:10:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 347E649 for ; Fri, 18 Mar 2016 05:09:29 -0700 (PDT) Received: from [10.2.206.221] (e107157-lin.cambridge.arm.com [10.2.206.221]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2F7253F21A for ; Fri, 18 Mar 2016 05:10:31 -0700 (PDT) Subject: [Patch testsuite obvious][gcc-5] g++.dg/ext/pr57735.C should not run if the testsuite is explicitly passing -mfloat-abi=hard To: GCC Patches References: <1433855261-6508-1-git-send-email-james.greenhalgh@arm.com> From: "Andre Vieira (lists)" Message-ID: <56EBF035.2030509@arm.com> Date: Fri, 18 Mar 2016 12:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1433855261-6508-1-git-send-email-james.greenhalgh@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg01088.txt.bz2 On 09/06/15 14:07, James Greenhalgh wrote: > > Hi, > > g++.dg/ext/pr57735.C is failing for test runs which explicitly pass > -mfloat-abi=hard. Looking at the test, it seems the best fix would be > to check before adding -mfloat-abi=soft that we are not testing some other > float-abi. We also fail to check that it is OK to add -march=armv5te > and -marm. > > Fixed using the same mechanisms we use elsewhere in the gcc.target/arm/ > tests with the attached, applied as obvious as revision 224280. > > Thanks, > James > > --- > gcc/testsuite/ > > 2015-06-09 James Greenhalgh > > * g++.dg/ext/pr57735.C: Do not override -mfloat-abi directives > passed by the testsuite driver. > Thomas committed this on my behalf to gcc-5-branch as obvious as revision r234326. Cheers, Andre