From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102635 invoked by alias); 18 Mar 2016 16:52:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102594 invoked by uid 89); 18 Mar 2016 16:52:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=pr70278c, multiword, pr70278.c, split_regs X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Mar 2016 16:52:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 0092880E47 for ; Fri, 18 Mar 2016 16:51:58 +0000 (UTC) Received: from slagheap.utah.redhat.com (ovpn-113-164.phx2.redhat.com [10.3.113.164]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2IGpweh024232; Fri, 18 Mar 2016 12:51:58 -0400 Subject: Re: Fix 70278 (LRA split_regs followup patch) To: Bernd Schmidt , GCC Patches , Vladimir Makarov References: <56EBF12B.40701@t-online.de> <56EBF3B9.5050005@redhat.com> From: Jeff Law Message-ID: <56EC322E.5080900@redhat.com> Date: Fri, 18 Mar 2016 16:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56EBF3B9.5050005@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg01102.txt.bz2 On 03/18/2016 06:25 AM, Bernd Schmidt wrote: > This fixes an oversight in my previous patch here. I used biggest_mode > in the assumption that if the reg was used in the function, it would be > set to something other than VOIDmode, but that fails if we have a > multiword access - only the first hard reg gets its biggest_mode > assigned in that case. > > Bootstrapped and tested on x86_64-linux, ran (just) the new arm testcase > manually with arm-eabi. Ok? > > (The testcase seems to be from glibc. Do we keep the copyright notices > on the reduced form)? I don't recall specific guidance on including the copyright notice on a reduced/derived test. Given the actual copyright on the original code, ISTM the safest thing to do is keep the notice intact. A long long time ago I receive guidance from the FSF WRT what could be included in the testsuite -- unfortunately I didn't keep that message. I probably should have. > > Bernd > > 70278.diff > > > PR rtl-optimization/70278 > * lra-constraints.c (split_reg): Handle the case where biggest_mode is > VOIDmode. > > testsuite/ > * gcc.dg/torture/pr70278.c: New test. > * gcc.target/arm/pr70278.c: New test. OK. jeff