public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bschmidt@redhat.com>
To: Jeff Law <law@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [RFA][PATCH] Adding missing calls to bitmap_clear
Date: Mon, 21 Mar 2016 19:39:00 -0000	[thread overview]
Message-ID: <56F0470F.6080804@redhat.com> (raw)
In-Reply-To: <56F0461C.3070601@redhat.com>

On 03/21/2016 08:06 PM, Jeff Law wrote:
>
> As noted last week, find_removable_extensions initializes several
> bitmaps, but doesn't clear them.
>
> This is not strictly a leak as the GC system should find dead data, but
> it's better to go ahead and clear the bitmaps.  That releases the
> elements back to the cache and presumably makes things easier for the GC
> system as well.
>
> Bootstrapped and regression tested on x86_64-linux-gnu.
>
> OK for the trunk?

Looks like they don't leak anywhere, so ok. Probably ok even to install 
it now but maybe stage1 would be better timing.


Bernd

  reply	other threads:[~2016-03-21 19:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 19:10 Jeff Law
2016-03-21 19:39 ` Bernd Schmidt [this message]
2016-03-21 20:40   ` Jeff Law
2016-03-22 10:22     ` Richard Biener
2016-04-28 19:35       ` Jeff Law
2016-04-29  8:06         ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F0470F.6080804@redhat.com \
    --to=bschmidt@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).