Re: [HSA, PATCH] Enhance dump output

["Martin Liška" <mliska@suse.cz>]

On 03/21/2016 06:44 PM, Martin Jambor wrote:
> ...please remove the added newlines here...
>
>> >+  if (symbol->m_directive_offset)
>> >+    fprintf (f, "             /* BRIG offset: %u", symbol->m_directive_offset);
> ...and I think you are missing an ending "*/" in the string you dump.
>

Sure, fixed.

>> >  }
>> >
>> >  /* Dump textual representation of HSA IL operand OP to file F.  */
>> >@@ -929,7 +933,8 @@ dump_hsa_insn_1 (FILE *f, hsa_insn_basic *insn, int *indent)
>> >  	    fprintf (f, ", ");
>> >  	}
>> >
>> >-      fprintf (f, "]");
>> >+      fprintf (f, "] /* default: BB %i */",
>> >+	       hsa_bb_for_bb (sbr->m_default_bb)->m_index);
> I think I've approved this already?

Yeah, but it was probably just a private email I sent.
Installed as r234379.

Thanks,
Martin

>
> Thanks,
>
> Martin
>