From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-423629-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 29118 invoked by alias); 21 Mar 2016 19:39:38 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 29081 invoked by uid 89); 21 Mar 2016 19:39:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Enhance
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 21 Mar 2016 19:39:36 +0000
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id BB1ECAB08	for <gcc-patches@gcc.gnu.org>; Mon, 21 Mar 2016 19:39:32 +0000 (UTC)
Subject: Re: [HSA, PATCH] Enhance dump output
To: GCC Patches <gcc-patches@gcc.gnu.org>
References: <56EFD78B.3010707@suse.cz> <20160321174419.GA21117@virgil.suse.cz>
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
Message-ID: <56F04DFC.5060000@suse.cz>
Date: Mon, 21 Mar 2016 19:55:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160321174419.GA21117@virgil.suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-03/txt/msg01201.txt.bz2

On 03/21/2016 06:44 PM, Martin Jambor wrote:
> ...please remove the added newlines here...
>
>> >+  if (symbol->m_directive_offset)
>> >+    fprintf (f, "             /* BRIG offset: %u", symbol->m_directive_offset);
> ...and I think you are missing an ending "*/" in the string you dump.
>

Sure, fixed.

>> >  }
>> >
>> >  /* Dump textual representation of HSA IL operand OP to file F.  */
>> >@@ -929,7 +933,8 @@ dump_hsa_insn_1 (FILE *f, hsa_insn_basic *insn, int *indent)
>> >  	    fprintf (f, ", ");
>> >  	}
>> >
>> >-      fprintf (f, "]");
>> >+      fprintf (f, "] /* default: BB %i */",
>> >+	       hsa_bb_for_bb (sbr->m_default_bb)->m_index);
> I think I've approved this already?

Yeah, but it was probably just a private email I sent.
Installed as r234379.

Thanks,
Martin

>
> Thanks,
>
> Martin
>