From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][ARM] Split out armv7ve effective target check
Date: Wed, 23 Mar 2016 11:09:00 -0000 [thread overview]
Message-ID: <56F270F3.8060405@foss.arm.com> (raw)
In-Reply-To: <CAJA7tRZfvYMhfafyxUnxikBS=NN0X7xxgOr6rO4CVkPEQaNk9w@mail.gmail.com>
On 16/03/16 15:54, Ramana Radhakrishnan wrote:
> On Wed, Mar 2, 2016 at 1:32 PM, Kyrill Tkachov
> <kyrylo.tkachov@foss.arm.com> wrote:
>> Hi all,
>>
>> I'm seeing the fails:
>> FAIL: gcc.target/arm/atomic_loaddi_2.c scan-assembler-times ldrd\tr[0-9]+,
>> r[0-9]+, \\[r[0-9]+\\] 1
>> FAIL: gcc.target/arm/atomic_loaddi_5.c scan-assembler-times ldrd\tr[0-9]+,
>> r[0-9]+, \\[r[0-9]+\\] 1
>> FAIL: gcc.target/arm/atomic_loaddi_8.c scan-assembler-times ldrd\tr[0-9]+,
>> r[0-9]+, \\[r[0-9]+\\] 1
>>
>> when testing an arm multilib with /-march=armv7-a.
>>
>> The tests have an effective target check for armv7ve but it doesn't work
>> because
>> under the hood the check is the same as for armv7-a, that is it checks for
>> the __ARM_ARCH_7A__
>> predefine which is set for both march values.
>>
>> To check for armv7ve using predefines we need to check for both
>> __ARM_ARCH_7A__ and for the hardware
>> integer division predefine, making armv7ve special.
>>
>> So this patch separates the effective target check definition from the rest
>> of the architectures
>> and defines it appropriately.
>>
>> With this patch the aforementioned tests appear UNSUPPORTED when testing the
>> /-march=armv7-a multilib.
>>
>> Ok for trunk?
> Ok, but please follow up with updating sourcebuild.texi.
sourcebuild.texi shouldn't need any updating as I'm not adding a new effective
target check, I'm just fixing the way one of the already existing ones is defined.
Committed with r234420.
Thanks,
Kyrill
>
> Ramana
>
>> Thanks,
>> Kyrill
>>
>> 2016-03-02 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * lib/target-supports.exp: Remove v7ve entry from loop
>> creating effective target checks.
>> (check_effective_target_arm_arch_v7ve_ok): New procedure.
>> (add_options_for_arm_arch_v7ve): Likewise.
next prev parent reply other threads:[~2016-03-23 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 13:32 Kyrill Tkachov
2016-03-09 9:33 ` Kyrill Tkachov
2016-03-16 15:54 ` Ramana Radhakrishnan
2016-03-23 11:09 ` Kyrill Tkachov [this message]
2016-03-23 11:29 ` Kyrill Tkachov
2016-03-23 11:41 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F270F3.8060405@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramana.gcc@googlemail.com \
--cc=ramana.radhakrishnan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).