From: Sandra Loosemore <sandra@codesourcery.com>
To: Bernd Schmidt <bschmidt@redhat.com>,
David Wohlferd <dw@LimeGreenSocks.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Henderson <rth@redhat.com>
Subject: Re: [DOC Patch] Add sample for @cc constraint
Date: Thu, 24 Mar 2016 17:59:00 -0000 [thread overview]
Message-ID: <56F428A1.6090109@codesourcery.com> (raw)
In-Reply-To: <56F40103.8080600@redhat.com>
On 03/24/2016 09:00 AM, Bernd Schmidt wrote:
> In principle we probably should have an example, but once again I have
> some problems with the style of the added documentation. I prefer
> concise writing without unnecessary repetition. Any other reviewers can
> of course override me, but the following is my opinion on these changes.
>
> More problematic than a lack of documentation is that I haven't been
> able to find an executable testcase. If you could adapt your example for
> use in gcc.target/i386, that would be even more important.
FAOD, I've been keeping my mouth shut on this patch because I am not at
all familiar with low-level x86 features, the example makes little sense
to me, and I can't make any useful suggestions of my own about how to
improve this section of the documentation. :-( Generally, though, I
agree with Bernd's preference for conciseness and not wandering off into
side discussions or repetition of material already covered elsewhere.
-Sandra
next prev parent reply other threads:[~2016-03-24 17:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 4:01 David Wohlferd
2016-03-23 7:02 ` David Wohlferd
2016-03-24 15:21 ` Bernd Schmidt
2016-03-24 17:59 ` Sandra Loosemore [this message]
2016-03-27 22:34 ` David Wohlferd
2016-03-29 12:10 ` Bernd Schmidt
2016-04-01 23:39 ` David Wohlferd
2016-04-11 22:49 ` David Wohlferd
2016-04-12 13:06 ` Bernd Schmidt
2016-04-15 23:13 ` David Wohlferd
2016-04-25 9:51 ` Bernd Schmidt
2016-04-26 0:16 ` David Wohlferd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F428A1.6090109@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=bschmidt@redhat.com \
--cc=dw@LimeGreenSocks.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).