From: Jeff Law <law@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: David Malcolm <dmalcolm@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix 69650, bogus line numbers from libcpp
Date: Fri, 25 Mar 2016 18:25:00 -0000 [thread overview]
Message-ID: <56F56452.2030501@redhat.com> (raw)
In-Reply-To: <56F45B40.4080405@redhat.com>
On 03/24/2016 03:25 PM, Jeff Law wrote:
> On 03/24/2016 09:20 AM, Bernd Schmidt wrote:
>>
>> Like this? No one has yet approved any better wording for the message,
>> so given that you said "it's not a regression" I've left it, but I would
>> now prefer "linemarker ignored due to incorrect nesting".
>>
>>
>> Bernd
>>
>> cpp-leave.diff
>>
>>
>> PR lto/69650
>> * directives.c (do_linemarker): Test for file left but not entered
>> here.
>> * line-map.c (linemap_add): Not here.
>>
>> PR lto/69650
>> * gcc.dg/pr69650.c: New test.
> OK.
>
> Also OK if you want to fixup the message.
And I just realized Bernd is out due to the holidays, so I went ahead
and committed this for him.
jeff
prev parent reply other threads:[~2016-03-25 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56E12FFF.6050800@t-online.de>
2016-03-10 8:40 ` Bernd Schmidt
2016-03-11 22:09 ` David Malcolm
2016-03-14 13:20 ` Bernd Schmidt
2016-03-21 14:58 ` Bernd Schmidt
2016-03-21 20:17 ` David Malcolm
2016-03-22 1:35 ` Bernd Schmidt
2016-03-23 12:58 ` Richard Biener
2016-03-23 13:21 ` Bernd Schmidt
2016-03-23 14:39 ` Richard Biener
2016-03-24 16:21 ` Bernd Schmidt
2016-03-24 21:42 ` Jeff Law
2016-03-25 18:25 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F56452.2030501@redhat.com \
--to=law@redhat.com \
--cc=bschmidt@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).