From: Bernd Schmidt <bschmidt@redhat.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR70484, RTL DSE using wrong dependence check
Date: Fri, 01 Apr 2016 15:26:00 -0000 [thread overview]
Message-ID: <56FE931D.4030604@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1604011106140.13384@t29.fhfr.qr>
On 04/01/2016 11:08 AM, Richard Biener wrote:
> {
> ! if (canon_true_dependence (s_info->mem,
> ! GET_MODE (s_info->mem),
> ! s_info->mem_addr,
> ! mem, mem_addr))
> {
> s_info->rhs = NULL;
> s_info->const_rhs = NULL;
> --- 1609,1617 ----
> the value of store_info. If it is, set the rhs to NULL to
> keep it from being used to remove a load. */
> {
> ! if (canon_output_dependence (s_info->mem, true,
> ! mem, GET_MODE (mem),
> ! mem_addr))
> {
> s_info->rhs = NULL;
> s_info->const_rhs = NULL;
I think the patch is ok, but there is a comment in that function which
references canon_true_dependence; that should also be fixed up.
Isn't the testcase invalid though? I thought accesses through char *
pointers bypass aliasing rules, but accessing a char array through int *
and long * pointers doesn't?
Bernd
next prev parent reply other threads:[~2016-04-01 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 9:08 Richard Biener
2016-04-01 9:19 ` Jakub Jelinek
2016-04-01 9:44 ` Richard Biener
2016-04-01 15:06 ` Jakub Jelinek
2016-04-01 15:17 ` Bernd Schmidt
2016-04-01 15:39 ` Jeff Law
2016-04-01 15:26 ` Bernd Schmidt [this message]
2016-04-01 17:25 ` Richard Biener
2016-04-04 9:24 ` Richard Biener
2016-04-04 9:36 ` Richard Biener
2016-04-04 9:50 ` Jakub Jelinek
2016-04-05 9:06 ` Richard Biener
2016-04-05 9:18 ` Jakub Jelinek
2016-04-05 9:48 ` Richard Biener
2016-04-05 9:51 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE931D.4030604@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).