From: Thomas Koenig <tkoenig@netcologne.de>
To: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>,
gcc-patches@gcc.gnu.org, "Thomas König" <tk@tkoenig.net>,
"Tobias Burnus" <tobias@codesourcery.com>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: [patch, fortran] Load scalar intent-in variables at the beginning of procedures
Date: Tue, 19 Nov 2019 23:04:00 -0000 [thread overview]
Message-ID: <56a5680e-5e48-4d74-dfca-0a083aae8a3c@netcologne.de> (raw)
In-Reply-To: <BA895BD6-3EB3-4AD2-9B06-C0567C8735AE@gmail.com>
Am 19.11.19 um 11:39 schrieb Bernhard Reutner-Fischer:
> + char name[GFC_MAX_SYMBOL_LEN + 1];
> + snprintf (name, GFC_MAX_SYMBOL_LEN, "__dummy_%d_%s", var_num++,
> + f->sym->name);
> +
> + if (gfc_get_sym_tree (name, ns, &symtree, false) != 0)
>
> (I) you should + sizeof(__dummy__) + 10 for unsigned long %d or the like.
GFC_MAX_SYMBOL_LEN is the maximum length of a gfortran symbol. AFAIK, it
is not possible to use a longer symbol name than that, so it needs to be
truncated. Uniqueness of the variable name is guaranteed by the var_num
variable.
If the user puts dummy arguments Supercalifragilisticexpialidociousa and
Supercalifragilisticexpialidociousb into the argument list of a
procedure, he will have to look at the numbers to differentiate them :-)
> (II) s/__dummy/__intent_in/ for clarity?
It's moved away a bit from INTENT(IN) now, because an argument which
cannot be modified (even by passing to a procedure with a dummy argument
with unknown intent) is now also handled.
Regards
Thomas
next prev parent reply other threads:[~2019-11-19 22:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 21:57 Thomas König
2019-11-11 22:08 ` Thomas Koenig
2019-11-11 22:53 ` Janne Blomqvist
2019-11-11 23:02 ` Thomas König
2019-11-12 7:48 ` Janne Blomqvist
2019-11-12 12:50 ` Thomas König
2019-11-12 14:33 ` Tobias Burnus
2019-11-12 17:22 ` Thomas König
2019-11-15 7:41 ` Tobias Burnus
2019-11-15 18:07 ` Thomas König
2019-11-16 20:42 ` Thomas Koenig
2019-11-19 10:46 ` Bernhard Reutner-Fischer
2019-11-19 23:04 ` Thomas Koenig [this message]
2019-11-20 18:00 ` Bernhard Reutner-Fischer
2019-11-20 20:45 ` Janne Blomqvist
2019-11-20 21:07 ` Steve Kargl
2019-11-20 21:35 ` Bernhard Reutner-Fischer
2019-11-20 20:46 ` Janne Blomqvist
2019-11-20 21:39 ` Thomas König
2019-11-20 22:19 ` Janne Blomqvist
2019-11-20 22:32 ` Janne Blomqvist
2019-11-21 9:35 ` Janne Blomqvist
2019-11-20 22:37 ` Tobias Burnus
2019-11-20 22:41 ` Thomas König
2019-11-20 22:30 ` Tobias Burnus
2019-11-21 9:41 ` Tobias Burnus
2019-11-21 12:30 ` Richard Biener
2019-11-21 13:17 ` Tobias Burnus
2019-11-21 13:37 ` Tobias Burnus
2019-11-21 14:10 ` Richard Biener
2019-11-21 14:39 ` Tobias Burnus
2019-11-22 10:44 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56a5680e-5e48-4d74-dfca-0a083aae8a3c@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
--cc=tk@tkoenig.net \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).