From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 449B83845850 for ; Wed, 14 Dec 2022 07:09:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 449B83845850 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BE73PJo026340 for ; Wed, 14 Dec 2022 07:09:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=0PN5l65EQyZRb+en0+ahSJAeavXkLvuZ5o87JG0KXSo=; b=bpbm7aUz6wV+W++mMVULtsEnDdIzaToGfW4/wPLkOqQb9DiR5WbbQW7vXK6vZrUkGM1z TTDYZWWGhSyXThb8cGb9W1bf6az/qmjaMQuoxgSfBkCJkbf+DtXjoP7EVq3LQAG7byl7 nYONbdpaoj8Ha/7iFaPCzhsch8PBcczjqO1cBaMr4DN673R8c2W+nQCnf/Dwm4BwczPE uN5zcwpFIQIqu964TDgqO8DptZfGKUghUE/Y+NIapOK5Jb29iHAA5JoKUPXSvZp0msZJ CwBXKmKq4iynVS9xjxAykCL/EgmPkD805u/uXgwdF2fiDlo2lDGfWi9R/RId/EFoarIA Ww== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyewsa23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Dec 2022 07:09:03 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BE6GIbJ031129 for ; Wed, 14 Dec 2022 07:09:03 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3meyeph2u1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Dec 2022 07:09:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d2va61UJWJg829R+eHC8SGVg3N/TpCU4dRqiK9ngT1ebtFLOU+HqsG4l4xOqqY9SdWl+8O6E2n9+UzlcYAr22xz/tlJ91UbcE0B9CVvAcGnk94VQ2gB4HUbVzgWJup4lfEQEV17nHcGQltyhB5x17sWiKqBbj+Ml9v0E4IWaPpKxEEob4koJhLYi6ChrWOfJiN8zpI7gUAuF7ujEgxWDdmoC+hvJiVhTopu8pvqyFYlGxIabMQr7YgSiDflte4lq+4AAaKxvr6M2Yv2Su6QUSdkxG6AA5xNzb39PUxmoJbfRuoVYBZ4XSzRQMBz8pCin/hNP18cjJIlzwWpMRdI+qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0PN5l65EQyZRb+en0+ahSJAeavXkLvuZ5o87JG0KXSo=; b=gB/AMI6Rg7fUO41s/t7qV5Wm74RMBpY0JgVXZLWBHkg6V61aEPsPfkLpLddu4C+P+qzff0V0R4cAsL1idoBMjdW5/2quIJIvWvKZKZAOLN0yn0y80efhPV7hZl6mSFppM2a45n3Mp/mZv2Y8YDdaoBTZ5qhJ0nZk4HlCBtLdXeglIMHNxQANB2hxFEx0qBGzi7r4YFHCm5Iy5+VzhGEWHfVnjXoeqMHS6K6O3Dy0+s6oq6cTKjw8+3WMDgUE1xcUt4NDdBv4/3tXyvqMmnHspOI9xIUB2FsfzsbNgkFrwTaOC9EF1z6N4bSLYwaMP3gBr4w+2piOSyCceh04wG93bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PN5l65EQyZRb+en0+ahSJAeavXkLvuZ5o87JG0KXSo=; b=QsYtmNlDM9cvVdvq1lr/WOpwwM0QIrNCxVAIquvTOAPTvVi9JwKi876/9JQaZAw9ZV5XDqMf5OrRlonCMDZ1YnLYP6TM3FVoD6vGXkHhLr1GDj+vUbhEdgqAQfqhfhtVUGQV1MJJ5C1k3OWOrR7rVDXt2psZHgC6E2t+RTJn+uQ= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB6376.namprd10.prod.outlook.com (2603:10b6:a03:485::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 07:09:01 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 07:09:00 +0000 Message-ID: <56aad541-656d-c8e2-4691-5e2ccad55678@oracle.com> Date: Tue, 13 Dec 2022 23:08:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 0/3] btf: fix BTF for extern items [PR106773] Content-Language: en-US To: David Faust , gcc-patches@gcc.gnu.org References: <20221213184426.8861-1-david.faust@oracle.com> From: Indu Bhagat In-Reply-To: <20221213184426.8861-1-david.faust@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0022.namprd03.prod.outlook.com (2603:10b6:303:8f::27) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB6376:EE_ X-MS-Office365-Filtering-Correlation-Id: 382beb25-6b66-4ea7-300e-08dadda2134f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wcGCZnOmeNlPI05qXdpv6Ty6M6nplvakyBh38084wu7oxu/dkqcIZUp+gDWVbjefYVTFHn1lOc01ywzkhja98qHib5WjGLWYxgf7APu8tpp3L6RnophPAnaFlSFrFmOZ/QKtLeinKIvFwwncANnnMSAK5wzVcF6Q9rXCFcnayPf7Z+X3Bepc42qc4Frrcya3JIeMB5+MocXBFPOZFr2wwz1BRtID1hXYhHQXL1fUpJsltW5TWrJiRlkNNHQWYpxY5wvs9gueSM3sEsJJYtQXViDNhASIj6zu5cF44sN2KsMv2aCjKkRuZD2VrZcCCj5Q17DNmhl3tnInc25C6pSJrY08kSNUygNJqLNrj0031d3wKL0oXHL+I4qPhdSMA5wrlT+ZPltLCrxE3aiAyDLoPNnt5Umr7M/NmUgAGqoBbbykibk8VYbJUHvpiuQwBIFz3OM8ICtQQ0rTtY7xbuo326heBxRgrwKU3xiYCLNrXStthNnewoNau/29yTF08YyoQtdSRDopB+A9gc+syUiZBEMDaIdRh41ICtRNTGvbcYKkC6DrYkcojQa1ZGnhRaQjLUaJPN1q8FV6QRyiLZHVLwf/3TE4vo/XVw/xHgqYjNMcgPGupNZU0aixi9T06fN8U1He23tDOAtTSeXOJRLEJI+sk37Ug2Fzt2CHGXHpDBnkaieER1aE8NDMWcAaLrYZnXV5rcWKSqn66GVJmXDscqz/gRq0adRvvCtSdqMmtKI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(83380400001)(44832011)(5660300002)(6666004)(8936002)(31686004)(38100700002)(41300700001)(36756003)(6486002)(186003)(2906002)(6506007)(66556008)(8676002)(2616005)(31696002)(53546011)(6512007)(66476007)(86362001)(66946007)(478600001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHBNUm8wSllUUmFxVk1id2VCb1RaTWlWenRiYkFLMkxQNzd4bFJTUVlUYnIv?= =?utf-8?B?VTBQMjcxY1dMM2J2U2I3WVNFWnNTZ3FRdzBDNkFHaHRjWVlPWjFGbHZlOVRm?= =?utf-8?B?OVFZR2VhNlRQRnhRUHZqOElxUDNkNlJXZkdiL0YrZTRFRkxZdWI5K2FNU2Qv?= =?utf-8?B?cldzRzlZRWUyR0o1emxQWmtlTzZWTE1SLzlBMlVya0ZuWk5zWkNVSnVzZWxu?= =?utf-8?B?NG4vY3RRL212ZG9XRC93WHhHRFhZcTRZZ1NEZkU0M3YybWR6UmQwenRUYkZY?= =?utf-8?B?NFMwMWMzbnorTTBFT0dyelRScmQ0TktmRnhGY3RoYXFOK25uYUQ3aWJzK2hI?= =?utf-8?B?NnorMXJ1SGNGZkZxSjRuVGRqcWhsTzRjM2NkOGFIOG91Ymw0c2tTS2RDZlIz?= =?utf-8?B?Rm9WQmYvemFtRlE0M1pUbnorZzN0S2pXREtmakJaUEluNjdoTFR1bUpTMHpo?= =?utf-8?B?WGNkRzVKWGVOSzFuVkVJUWw2cW9OazdkSWIwVzUwclZDaTIydHNZM1g4b2tV?= =?utf-8?B?Q0FDZDc3WDFiMExLTUhSVU9sSlBUOVBFajBhdmw4SzJzWmZuTSt2dWpYcFRt?= =?utf-8?B?Zmw4NEt5ZURVYXltMGtlSGJpU3B6ZmxiSUswVElRcnVELzlPSnI1d0pqa1NT?= =?utf-8?B?aUhnRFJ6ZFdSaEViWHF4TjgzbnQ5UFRSYVpzanpUZERCSUVHY1ZWL1htTlox?= =?utf-8?B?Z256RkpUdGlYeTlPd0dTc3hQdDFTbk9SbmhKRE9OWnNmV2tkS1BtdzJKNFo5?= =?utf-8?B?T2ZUNlc2alZhR045TWZNNkF0S1pBb3E5Q3lhR0hxdGRMajI4bk5xbHpaeW03?= =?utf-8?B?TjJLbFlMS2l0Q1lQeE8zUU92dlhhdVhEVGRQdllpZzY3QWdVa3ZBVjg2dWh4?= =?utf-8?B?aTR2eXpZa3VSWENQSXJCdTczcXJKN0dEKzA5L3JOenBOWERiVmxyaDIyNlBn?= =?utf-8?B?WEEwbW9OcWtHL04vclcvdXdSTTEydVdUNGFlZythZXJBUUhBUWtFMzZIbWdp?= =?utf-8?B?YUExekNJOEt6QXdIQ1B4SUtHeXEwSDYyZ0dueHJWdWhhWGhpTGlGZ25DdDJj?= =?utf-8?B?ZEZkUFJ3OUFJK0RsYzE2MjVYUFB6MXlKeXAxQWZBVGVpUmh6VHBOVk9WaDAr?= =?utf-8?B?cUVuM0dHQUVhWVNzUC8rdi9hdDYzeDBsaHk2RmM1Q3gwcTZwMTBoL1hQWkN5?= =?utf-8?B?UjA5em1mRGxhcFNzUWw5RGFkam1xdzJoOWMxMDQ4djNWK1N1UmpVTXJTeVRB?= =?utf-8?B?MlVjRDd6ZEF5NUpHZWRzOTVRRk9PdnVwdnVpWUFqUGhad24rQml2Y3UzNGN1?= =?utf-8?B?eHpTcmkwaFdkV3lPbjFBUXoxTUh2cTRzWGhaUlBmM3NTWGlmQTcxdWpiNkdU?= =?utf-8?B?NXdxZVRjUnBxVkR6aGQzUEFBbTVtMi9USmwrL2drWjBXTmdsYmRXMzBneUwz?= =?utf-8?B?K2NOWHJZVzJVQkNjSlBIREZPZ0M3am5VVDNVOTJpSHBTSmtMakhzcFB6L1NP?= =?utf-8?B?SFNtRDB5QVZsemN2dS9BbGk1dmZVTDF5K1VEUVo0RitWMWg5UURwYkNsMWhF?= =?utf-8?B?cEFJdldIT2NJRFVnZlA5dHp0RjgyZFBTMXBxWGd2VVg2UndtWmpJdVU3aVlq?= =?utf-8?B?dmZ0cmlGbkNCcW5rSWZBTnp4MmJjZzk0L2Z3Y2xkMVlhNGZLS1FLSXZRK2s3?= =?utf-8?B?bjVFYzZzMldDWmZwOUhsV2pJczN3TG1IYjQ3U2o0TXVGMDBIYVB2dVQ2SFpk?= =?utf-8?B?NFB4c0xLc1NHaEpuMWxUd2MxbDN3aUVhOGdsbmZYMW5TLzRvbVBwUld1UWYr?= =?utf-8?B?WWhSTkZ0eXZqMzg0L2VIcjB6V2lYM1RhNFNIODFtNEN3aWlPYTVsN2VBeXFz?= =?utf-8?B?QTYrM1lsUVVJQmgvQmp4cGVtVEZzL0ZhcFI1Vll4b20vWkFubGpUSEpJY0p4?= =?utf-8?B?TFZxeVVhb090L0ZlWHg4YlczRUpnZTBqZkN4Si9iMXVyZGxaMkFPbHRoQ0R3?= =?utf-8?B?ckJtbXNxbE5NSzNvcXdIb2IzNm4wL3F0Q3ZEWXAvMm1Qb1hpbGJHM081cTJP?= =?utf-8?B?cGJURE5rLzAwOWsvSWFSK2ZlT3puRGZqMkJvSXNBK2dMWHRqL1NxRnd5VzlD?= =?utf-8?B?b21mSW9xRkZ5NkoxWVBMYWJEd1RCQ0M3YThKQU55RnJRcStlN2JuSDdlL3M2?= =?utf-8?B?dlE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 382beb25-6b66-4ea7-300e-08dadda2134f X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 07:09:00.7555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iVJXf3xO6J5QP3Q6HL8BX1qe5P6ORAJl1V/7dnmAhIWVmN7WkX9gUTyYCFdm2Rlh8zpB3jmPpzawAYKsN7HCVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6376 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-14_03,2022-12-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212140053 X-Proofpoint-GUID: qAYYNbB5mY87YwUPlH3dAWrdS3nUbMeY X-Proofpoint-ORIG-GUID: qAYYNbB5mY87YwUPlH3dAWrdS3nUbMeY X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/13/22 10:44, David Faust wrote: > [Changes from v1: > - Remove #defines for LINKAGE_* values, instead mirror enums from > linux/btf.h to include/btf.h and use those. > - Fix BTF generation for extern variable with both non-defining and > defining decls in the same CU. Add a test for this. > - Update several comments per review feedback. ] > > Hi, > > This series fixes the issues reported in target/PR106773. I decided to > split it into three commits, as there are ultimately three distinct > issues and fixes. See each patch for details. > > Tested on bpf-unknown-none and x86_64-linux-gnu, no known regressions. > > OK to push? > Thanks. > Hi David, LGTM. Thanks > David Faust (3): > btf: add 'extern' linkage for variables [PR106773] > btf: fix 'extern const void' variables [PR106773] > btf: correct generation for extern funcs [PR106773] > > gcc/btfout.cc | 184 +++++++++++++----- > .../gcc.dg/debug/btf/btf-datasec-2.c | 28 +++ > .../gcc.dg/debug/btf/btf-function-6.c | 19 ++ > gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c | 25 +++ > .../gcc.dg/debug/btf/btf-variables-4.c | 24 +++ > .../gcc.dg/debug/btf/btf-variables-5.c | 19 ++ > include/btf.h | 29 ++- > 7 files changed, 276 insertions(+), 52 deletions(-) > create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-datasec-2.c > create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-function-6.c > create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c > create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-variables-4.c > create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-variables-5.c >