From: Stephan Bergmann <sbergman@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>,
Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Diagnose visitors with different return types [PR95904]
Date: Sat, 17 Oct 2020 19:30:05 +0200 [thread overview]
Message-ID: <56d88a36-351d-a000-b5ae-8f4c18791285@redhat.com> (raw)
In-Reply-To: <20201008142706.GM7004@redhat.com>
On 08/10/2020 16:27, Jonathan Wakely via Gcc-patches wrote:
> On 05/10/20 22:35 +0300, Ville Voutilainen via Libstdc++ wrote:
>> On Mon, 5 Oct 2020 at 01:15, Ville Voutilainen
>> <ville.voutilainen@gmail.com> wrote:
>>> The patch is borked, doesn't pass tests, fixing...
>>
>> Unborked, ok for trunk if full testsuite passes?
>
> Assuming it has passed by now, OK. Thanks.
Clang (with -std=c++17/20) now complains about
> include/c++/11.0.0/variant:1032:10: error: no matching constructor for initialization of 'std::__nonesuch'
> return __nonesuch{};
> ^ ~~
> include/c++/11.0.0/type_traits:2953:5: note: candidate constructor not viable: requires 1 argument, but 0 were provided
> __nonesuch(__nonesuch const&) = delete;
> ^
upon #include <variant>. (And I think legitimately so, as __nonsuch is
not dependent?)
next prev parent reply other threads:[~2020-10-17 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 22:12 [PATCH] c++: Diagnose visitors with different return types for std::visit [PR95904] Ville Voutilainen
2020-09-29 11:20 ` Jonathan Wakely
2020-09-29 16:35 ` [PATCH] libstdc++: Diagnose visitors with different return types [PR95904] Ville Voutilainen
2020-10-02 22:14 ` Jonathan Wakely
2020-10-04 22:15 ` Ville Voutilainen
2020-10-05 19:35 ` Ville Voutilainen
2020-10-08 14:27 ` Jonathan Wakely
2020-10-17 17:30 ` Stephan Bergmann [this message]
2020-10-17 17:36 ` Ville Voutilainen
2020-10-10 10:52 ` Jonathan Wakely
2020-10-10 11:15 ` Ville Voutilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d88a36-351d-a000-b5ae-8f4c18791285@redhat.com \
--to=sbergman@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).