From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>, Iain Sandoe <iain@sandoe.co.uk>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgcc: Fix __builtin_nested_func_ptr_{created,deleted} symbol versions [PR113402]
Date: Tue, 16 Jan 2024 09:45:28 +0100 (CET) [thread overview]
Message-ID: <570217r4-0psq-4n07-4667-p65718778nq8@fhfr.qr> (raw)
In-Reply-To: <ZaY8/lXoOQ82jN//@tucnak>
On Tue, 16 Jan 2024, Jakub Jelinek wrote:
> Hi!
>
> These symbols were exported at an incorrect symbol version,
> the following patch fixes that.
>
> I believe we should also rename the symbols (__nested_func_ptr_*
> or __gcc_nested_func_ptr_* or similar), __builtin_ in the name
> doesn't look right, but that will need more changes to make it
> work.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK, but maybe squash with the renaming.
> 2024-01-16 Jakub Jelinek <jakub@redhat.com>
>
> PR libgcc/113402
> * libgcc-std.ver.in (GCC_7.0.0): Move
> __builtin_nested_func_ptr_created and
> __builtin_nested_func_ptr_deleted from this symbol version to ...
> (GCC_14.0.0): ... this one.
>
> --- libgcc/libgcc-std.ver.in.jj 2024-01-03 12:07:29.751347757 +0100
> +++ libgcc/libgcc-std.ver.in 2024-01-15 17:55:16.064728452 +0100
> @@ -1943,9 +1943,6 @@ GCC_4.8.0 {
> GCC_7.0.0 {
> __PFX__divmoddi4
> __PFX__divmodti4
> -
> - __builtin_nested_func_ptr_created
> - __builtin_nested_func_ptr_deleted
> }
>
> %inherit GCC_14.0.0 GCC_7.0.0
> @@ -1960,4 +1957,6 @@ GCC_14.0.0 {
> __PFX__strub_enter
> __PFX__strub_update
> __PFX__strub_leave
> + __builtin_nested_func_ptr_created
> + __builtin_nested_func_ptr_deleted
> }
>
> Jakub
>
>
prev parent reply other threads:[~2024-01-16 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 8:23 Jakub Jelinek
2024-01-16 8:45 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570217r4-0psq-4n07-4667-p65718778nq8@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).