From: Jason Merrill <jason@redhat.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ PATCH] PR 70501, ICE in verify ctor sanity
Date: Wed, 06 Apr 2016 14:49:00 -0000 [thread overview]
Message-ID: <570521EC.4070104@redhat.com> (raw)
In-Reply-To: <57042C71.5000205@acm.org>
On 04/05/2016 05:21 PM, Nathan Sidwell wrote:
> On 04/05/16 12:40, Jason Merrill wrote:
>
>> It's not clear to me that we really need a TARGET_EXPR for vector values. Since
>> one element of a vector can't refer to another, we don't need the ctx->ctor
>> handling. Perhaps we should handle vectors like we do PMF types in
>> cxx_eval_bare_aggregate?
>
> That may be abstractly better, but we do currently wrap constructors in
> target_exprs for vector compound_literals (which is what I was
> following). See the get_target_expr_sfinae calls in
> finish_compound_literal for instance. That happens for the '(v4si){(0,
> 0)}' subexpression of the testcase.
Sure, but that also seems unnecessary; vector rvalues don't have object
identity the way class and array rvalues do.
Jason
next prev parent reply other threads:[~2016-04-06 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:26 Nathan Sidwell
2016-04-05 19:40 ` Jason Merrill
2016-04-05 21:21 ` Nathan Sidwell
2016-04-06 14:49 ` Jason Merrill [this message]
2016-04-06 15:07 ` Nathan Sidwell
2016-04-07 15:18 ` Nathan Sidwell
2016-04-12 15:11 ` Jason Merrill
2016-04-12 19:41 ` [committed] Add PR c++/70571 testcase Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570521EC.4070104@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).