From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: James Greenhalgh <james.greenhalgh@arm.com>, gcc-patches@gcc.gnu.org
Cc: marcus.shawcroft@arm.com, richard.earnshaw@arm.com
Subject: Re: [Patch AArch64 3/3] Fix up for pr70133
Date: Thu, 07 Apr 2016 12:23:00 -0000 [thread overview]
Message-ID: <57065148.5080502@foss.arm.com> (raw)
In-Reply-To: <1459937403-22657-4-git-send-email-james.greenhalgh@arm.com>
Hi all,
On 06/04/16 11:10, James Greenhalgh wrote:
> Hi,
>
> Having updated the way we parse and output extension strings, now we just
> need to wire up the native detection to use these new features.
>
> In doing some cleanup and rename I ended up fixing 8-spaces to tabs in
> about half the file. I've done the rest while I'm here to save us from
> some a mixed-style file.
>
> Bootstrapped on aarch64-none-linux-gnu, then tested with defaults and
> an explicit -march=native passed (on a system detected as
> cortex-a57+crypto, and again on a system detected as
> cortex-a72.cortex-a53+crypto). I also set up a dummy /proc/cpuinfo and
> used that to manually check the input data in pr70133.
>
> OK?
This looks good to me (but I can't approve).
Thanks,
Kyrill
> Thanks,
> James
>
> ---
> 2016-04-06 James Greenhalgh <james.greenhalgh@arm.com>
>
> PR target/70133
>
> * config/aarch64/driver-aarch64.c
> (aarch64_get_extension_string_for_isa_flags): New.
> (arch_extension): Rename to...
> (aarch64_arch_extension): ...This.
> (ext_to_feat_string): Rename to...
> (aarch64_extensions): ...This.
> (aarch64_core_data): Keep track of architecture extension flags.
> (cpu_data): Rename to...
> (aarch64_cpu_data): ...This.
> (aarch64_arch_driver_info): Keep track of architecture extension
> flags.
> (get_arch_name_from_id): Rename to...
> (get_arch_from_id): ...This, change return type.
> (host_detect_local_cpu): Update and reformat for renames, handle
> extensions through common infrastructure.
>
next prev parent reply other threads:[~2016-04-07 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 10:10 [Patch AArch64 0/3] Fix PR70133 James Greenhalgh
2016-04-06 10:10 ` [Patch AArch64 2/3] Rework the code to print extension strings (pr70133) James Greenhalgh
2016-04-06 10:10 ` [Patch AArch64 1/3] Enable CRC by default for armv8.1-a James Greenhalgh
2016-04-07 15:24 ` Christophe Lyon
2016-04-07 16:52 ` James Greenhalgh
2016-04-06 10:11 ` [Patch AArch64 3/3] Fix up for pr70133 James Greenhalgh
2016-04-07 12:23 ` Kyrill Tkachov [this message]
2016-04-11 9:22 ` James Greenhalgh
2016-04-11 9:58 ` [Patch AArch64 0/3] Fix PR70133 Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57065148.5080502@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).