public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bschmidt@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Jeff Law <law@redhat.com>,
	       Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org, Andrew Pinski <pinskia@gmail.com>,
	       "H.J. Lu" <hjl.tools@gmail.com>,
	       Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Subject: Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)
Date: Tue, 12 Apr 2016 20:02:00 -0000	[thread overview]
Message-ID: <570D544A.6080101@redhat.com> (raw)
In-Reply-To: <20160412151011.GW19207@tucnak.redhat.com>

On 04/12/2016 05:10 PM, Jakub Jelinek wrote:
> This patch arranges for a new argument to
> convert_memory_address_addr_space_1 and calls it with that new argument set
> to true, to make sure it never emits instructions or creates pseudos.

I think the approach looks sensible, but I don't know if you need the 
extra argument. It looks like convert_memory_address_addr_space_1 
currently only has one user, can't you move the convert_modes call up 
into that function so that convert_memory_address_addr_space_1 never 
emits anything?


Bernd

  parent reply	other threads:[~2016-04-12 20:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 15:10 Jakub Jelinek
2016-04-12 19:11 ` H.J. Lu
2016-04-12 20:02 ` Bernd Schmidt [this message]
2016-04-12 20:07   ` Jakub Jelinek
2016-04-12 20:14     ` Bernd Schmidt
2016-04-12 20:34       ` Jakub Jelinek
2016-04-13  8:09         ` Andreas Schwab
2016-04-13 13:48         ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570D544A.6080101@redhat.com \
    --to=bschmidt@redhat.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=jakub@redhat.com \
    --cc=kyrylo.tkachov@foss.arm.com \
    --cc=law@redhat.com \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).