From: Bernd Schmidt <bschmidt@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: Martin Jambor <mjambor@suse.cz>, Jakub Jelinek <jakub@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: Splitting up gcc/omp-low.c?
Date: Wed, 13 Apr 2016 18:20:00 -0000 [thread overview]
Message-ID: <570E8DE3.6070007@redhat.com> (raw)
In-Reply-To: <87r3e94cku.fsf@hertz.schwinge.homeip.net>
On 04/13/2016 07:56 PM, Thomas Schwinge wrote:
>> Best way to present this might be to do
>> diff -du old-omp-low.c <each of the split files>.
>
> OK, I found Git "-C5%" produce something very similar to that;
> 0001-Split-up-gcc-omp-low.c-plain.patch.xz attached.
That looks much better. However, the //OMPWHATEVER comments are not
really all that helpful. I think the next step would be to clear out all
this stuff including the OMPCUT markers, and also to start with an
initial patch that includes everything that actually modifies code
rather than moving it (omp_is_reference seems to be the major thing here).
Bernd
next prev parent reply other threads:[~2016-04-13 18:20 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 11:18 [hsa 0/10] Merge of HSA branch Martin Jambor
2015-12-07 11:19 ` [hsa 1/10] Configury changes and new options Martin Jambor
2015-12-08 22:43 ` Richard Sandiford
2015-12-10 17:52 ` Martin Jambor
2015-12-11 17:42 ` Jakub Jelinek
2015-12-10 17:52 ` Martin Jambor
2015-12-07 11:20 ` [hsa 3/10] HSA libgomp plugin Martin Jambor
2015-12-09 12:16 ` Jakub Jelinek
2015-12-10 12:06 ` [hsa 3/10] HSA libgomp plugin [part 1/2] Martin Liška
2015-12-10 12:06 ` [hsa 3/10] HSA libgomp plugin [part 2/2] Martin Liška
2015-12-07 11:20 ` [hsa 2/10] Modifications to libgomp proper Martin Jambor
2015-12-09 11:55 ` Jakub Jelinek
2015-12-10 17:52 ` Martin Jambor
2015-12-11 18:05 ` Jakub Jelinek
2016-01-12 13:46 ` Martin Jambor
2016-01-12 14:23 ` Jakub Jelinek
2016-01-15 20:00 ` Jakub Jelinek
2016-01-12 13:00 ` Alexander Monakov
2016-01-12 13:10 ` Jakub Jelinek
[not found] ` <20160112132905.GM3060@virgil.suse.cz>
2016-01-12 13:38 ` Jakub Jelinek
2016-01-12 18:51 ` Martin Jambor
2015-12-07 11:21 ` [hsa 4/10] Merge of HSA branch Martin Jambor
2015-12-09 12:17 ` Jakub Jelinek
2015-12-07 11:23 ` [hsa 5/10] OpenMP lowering/expansion changes (gridification) Martin Jambor
2015-12-09 13:19 ` Jakub Jelinek
2015-12-09 16:25 ` Splitting up gcc/omp-low.c? (was: [hsa 5/10] OpenMP lowering/expansion changes (gridification)) Thomas Schwinge
2015-12-09 17:23 ` Splitting up gcc/omp-low.c? Bernd Schmidt
2015-12-10 8:08 ` Jakub Jelinek
2015-12-10 11:26 ` Bernd Schmidt
2015-12-10 11:34 ` Jakub Jelinek
2015-12-15 18:28 ` Nathan Sidwell
2016-04-08 9:36 ` Thomas Schwinge
2016-04-08 10:46 ` Martin Jambor
2016-04-08 11:08 ` Jakub Jelinek
2016-04-13 16:01 ` Thomas Schwinge
2016-04-13 17:38 ` Bernd Schmidt
2016-04-13 17:56 ` Thomas Schwinge
2016-04-13 18:20 ` Bernd Schmidt [this message]
2016-04-14 13:36 ` Thomas Schwinge
2016-04-14 16:01 ` Bernd Schmidt
2016-04-14 16:01 ` Thomas Schwinge
2016-04-14 20:28 ` Split out OMP constructs' SIMD clone supporting code (was: Splitting up gcc/omp-low.c?) Thomas Schwinge
2016-04-15 6:25 ` Split out OMP constructs' SIMD clone supporting code Thomas Schwinge
2016-04-15 11:15 ` Split out OMP constructs' SIMD clone supporting code (was: Splitting up gcc/omp-low.c?) Jakub Jelinek
2016-04-15 11:53 ` Thomas Schwinge
2016-04-15 11:57 ` Jakub Jelinek
2016-04-15 12:11 ` Thomas Schwinge
2016-04-15 12:15 ` Jakub Jelinek
2016-04-15 14:33 ` Thomas Schwinge
2016-05-03 9:34 ` Splitting up gcc/omp-low.c? Thomas Schwinge
2016-05-11 13:44 ` Thomas Schwinge
2016-05-18 11:42 ` Thomas Schwinge
2016-05-25 9:17 ` Thomas Schwinge
2016-05-25 12:54 ` Martin Jambor
2015-12-18 14:29 ` [hsa 5/10] OpenMP lowering/expansion changes (gridification) Martin Jambor
2015-12-07 11:24 ` [hsa 6/10] Pass manager changes Martin Jambor
2015-12-09 13:20 ` Jakub Jelinek
2015-12-09 13:47 ` Richard Biener
2015-12-07 11:25 ` [hsa 7/10] IPA-HSA pass Martin Jambor
2015-12-07 11:27 ` [hsa 8/10] HSAIL BRIG description header file (and a steering committee request) Martin Jambor
2015-12-07 11:29 ` [hsa 9/10] Majority of the HSA back-end Martin Jambor
2015-12-07 11:30 ` [hsa 10/10] HSA register allocator Martin Jambor
2015-12-07 11:46 ` [hsa 0/10] Merge of HSA branch Jakub Jelinek
2015-12-10 17:51 ` Martin Jambor
2016-01-26 10:46 ` (Non-)offloading diagnostics (was: [hsa 0/10] Merge of HSA branch) Thomas Schwinge
2016-01-26 11:18 ` Alexander Monakov
2016-01-26 11:38 ` (Non-)offloading diagnostics Thomas Schwinge
2016-02-26 16:46 ` Thomas Schwinge
2016-02-26 17:18 ` Martin Jambor
2016-02-26 17:51 ` Jakub Jelinek
2016-02-26 18:48 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E8DE3.6070007@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mjambor@suse.cz \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).