public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH][combine] Check WORD_REGISTER_OPERATIONS normally rather than through preprocessor
Date: Sun, 17 Apr 2016 21:25:00 -0000	[thread overview]
Message-ID: <5713EF1B.1040706@redhat.com> (raw)
In-Reply-To: <567048DD.4050100@foss.arm.com>

On 12/15/2015 10:07 AM, Kyrill Tkachov wrote:
> Hi all,
>
> As part of the war on conditional compilation here's an #if check on
> WORD_REGISTER_OPERATIONS that
> seems to have been missed out.
>
> Bootstrapped and tested on arm, aarch64, x86_64.
>
> Is it still ok to commit these kinds of conditional compilation
> conversions?
>
> Thanks,
> Kyrill
>
> 2015-12-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * combine.c (simplify_comparison): Convert preprocessor check of
>      WORD_REGISTER_OPERATIONS into runtime check.
This patch, and others like it are fine for the trunk (gcc-7) again.

I'll channel the release managers' request that we don't make large 
scale changes that would make backporting patches exceedingly difficult. 
  So just keep that in mind if you find more conditionally compiled code 
to kill.

jeff

  parent reply	other threads:[~2016-04-17 21:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 17:07 Kyrill Tkachov
2015-12-17 14:49 ` Segher Boessenkool
2015-12-22 10:39   ` Kyrill Tkachov
2016-04-17 21:25 ` Jeff Law [this message]
2016-04-18  9:33   ` Kyrill Tkachov
2016-04-21 11:37     ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5713EF1B.1040706@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@foss.arm.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).