From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120446 invoked by alias); 17 Apr 2016 21:25:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114840 invoked by uid 89); 17 Apr 2016 21:23:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=conversions, war X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 17 Apr 2016 21:22:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D3C1A627CF; Sun, 17 Apr 2016 21:22:55 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3HLMsr6015729; Sun, 17 Apr 2016 17:22:55 -0400 Subject: Re: [PATCH][combine] Check WORD_REGISTER_OPERATIONS normally rather than through preprocessor To: Kyrill Tkachov , GCC Patches References: <567048DD.4050100@foss.arm.com> Cc: Segher Boessenkool From: Jeff Law Message-ID: <5713EF1B.1040706@redhat.com> Date: Sun, 17 Apr 2016 21:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <567048DD.4050100@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00801.txt.bz2 On 12/15/2015 10:07 AM, Kyrill Tkachov wrote: > Hi all, > > As part of the war on conditional compilation here's an #if check on > WORD_REGISTER_OPERATIONS that > seems to have been missed out. > > Bootstrapped and tested on arm, aarch64, x86_64. > > Is it still ok to commit these kinds of conditional compilation > conversions? > > Thanks, > Kyrill > > 2015-12-15 Kyrylo Tkachov > > * combine.c (simplify_comparison): Convert preprocessor check of > WORD_REGISTER_OPERATIONS into runtime check. This patch, and others like it are fine for the trunk (gcc-7) again. I'll channel the release managers' request that we don't make large scale changes that would make backporting patches exceedingly difficult. So just keep that in mind if you find more conditionally compiled code to kill. jeff