From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109062 invoked by alias); 25 Aug 2017 05:05:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92687 invoked by uid 89); 25 Aug 2017 05:00:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Aug 2017 05:00:10 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 481F581DFD; Fri, 25 Aug 2017 05:00:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 481F581DFD Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law@redhat.com Received: from localhost.localdomain (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 192106B8E0; Fri, 25 Aug 2017 05:00:08 +0000 (UTC) Subject: Re: [70/77] Make expand_fix/float check for scalar modes To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org References: <8760ewohsv.fsf@linaro.org> <87r2xkbtes.fsf@linaro.org> From: Jeff Law Message-ID: <5713dafc-0645-c00b-15cd-767177e5b0c1@redhat.com> Date: Fri, 25 Aug 2017 08:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <87r2xkbtes.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg01491.txt.bz2 On 07/13/2017 03:03 AM, Richard Sandiford wrote: > The expand_float code: > > /* Unsigned integer, and no way to convert directly. Convert as signed, > then unconditionally adjust the result. */ > > and the expand_fix code: > > /* For an unsigned conversion, there is one more way to do it. > If we have a signed conversion, we generate code that compares > the real value to the largest representable positive number. If if > is smaller, the conversion is done normally. Otherwise, subtract > one plus the highest signed number, convert, and add it back. > > are restricted to scalars, since the expansion branches on a > comparison of the value. This patch makes that explicit. > > 2017-07-13 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * optabs.c (expand_float): Explicitly check for scalars before > using a branching expansion. > (expand_fix): Likewise. OK. jeff