Re: [PATCH][combine] Check WORD_REGISTER_OPERATIONS normally rather than through preprocessor

[Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>]

Hi Jeff,

On 17/04/16 21:16, Jeff Law wrote:
> On 12/15/2015 10:07 AM, Kyrill Tkachov wrote:
>> Hi all,
>>
>> As part of the war on conditional compilation here's an #if check on
>> WORD_REGISTER_OPERATIONS that
>> seems to have been missed out.
>>
>> Bootstrapped and tested on arm, aarch64, x86_64.
>>
>> Is it still ok to commit these kinds of conditional compilation
>> conversions?
>>
>> Thanks,
>> Kyrill
>>
>> 2015-12-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>      * combine.c (simplify_comparison): Convert preprocessor check of
>>      WORD_REGISTER_OPERATIONS into runtime check.
> This patch, and others like it are fine for the trunk (gcc-7) again.
>

Thanks, but I've committed this already in December after approval from Segher
(https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01771.html)

> I'll channel the release managers' request that we don't make large scale changes that would make backporting patches exceedingly difficult.  So just keep that in mind if you find more conditionally compiled code to kill.
>

I do have some cleanups like that, but I'll post them after the release. I'm in no hurry to get
them in right this moment.

Thanks,
Kyrill

> jeff