From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28923 invoked by alias); 14 Dec 2007 07:25:19 -0000 Received: (qmail 28905 invoked by uid 22791); 14 Dec 2007 07:25:18 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.177) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Dec 2007 07:25:14 +0000 Received: by py-out-1112.google.com with SMTP id a29so3470344pyi.0 for ; Thu, 13 Dec 2007 23:25:12 -0800 (PST) Received: by 10.142.77.11 with SMTP id z11mr1301532wfa.98.1197617111597; Thu, 13 Dec 2007 23:25:11 -0800 (PST) Received: by 10.143.19.15 with HTTP; Thu, 13 Dec 2007 23:25:11 -0800 (PST) Message-ID: <571f6b510712132325u2db2bf35g32152a11ea8049b4@mail.gmail.com> Date: Fri, 14 Dec 2007 07:59:00 -0000 From: "Steven Bosscher" To: "Hans-Peter Nilsson" Subject: Re: PR33713: remove -fforce-addr Cc: aldyh@redhat.com, gcc-patches@gcc.gnu.org In-Reply-To: <200712140157.lBE1vVxp003497@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071204231335.GA3822@redhat.com> <200712140157.lBE1vVxp003497@ignucius.se.axis.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00644.txt.bz2 On Dec 14, 2007 2:57 AM, Hans-Peter Nilsson wrote: > > Date: Tue, 4 Dec 2007 19:13:35 -0400 > > From: Aldy Hernandez > > > > Anyway, the point of this communication: was it really a good > > > thing to remove all test-cases using -fforce-addr? Why not just > > > remove their -fforce-addr argument? Can we add them back? > > > > I don't have a problem with that. Steven? > > Any news on this? IMHO without -fforce-addr the test cases test nothing that isn't already triggered by a gcc build or by another test case. I see no point in keeping aruond test cases that add no test coverage. Gr. Steven Index: testsuite/gcc.c-torture/compile/20050802-1.c =================================================================== --- testsuite/gcc.c-torture/compile/20050802-1.c (revision 130511) +++ testsuite/gcc.c-torture/compile/20050802-1.c (working copy) @@ -1,10 +0,0 @@ -/* PR 23196 */ -/* { dg-options "-fforce-addr" } */ - -void foo() -{ - char c; - - c |= 1; - bar(&c); -} Index: testsuite/gcc.dg/20011113-1.c =================================================================== --- testsuite/gcc.dg/20011113-1.c (revision 130511) +++ testsuite/gcc.dg/20011113-1.c (working copy) @@ -1,16 +0,0 @@ -/* Copyright (C) 2001 Free Software Foundation. - by Hans-Peter Nilsson */ - -/* { dg-do compile } */ -/* { dg-options "-O2 -fforce-addr" } */ - -const char foo[] = "fum"; -const struct fi -{ - const char *const in; - const char *const out; - const int flags; -} fie[] = { - {"nw", " new", 0}, - {"dl", foo, 1} -};