From: "Steven Bosscher" <stevenb.gcc@gmail.com>
To: "Hans-Peter Nilsson" <hans-peter.nilsson@axis.com>
Cc: aldyh@redhat.com, gcc-patches@gcc.gnu.org
Subject: Re: PR33713: remove -fforce-addr
Date: Fri, 14 Dec 2007 13:32:00 -0000 [thread overview]
Message-ID: <571f6b510712140528ib0a1ca8m74567b8cc19d8403@mail.gmail.com> (raw)
In-Reply-To: <200712141151.lBEBpnP7011641@ignucius.se.axis.com>
On Dec 14, 2007 12:51 PM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
> > Date: Fri, 14 Dec 2007 08:25:11 +0100
> > From: "Steven Bosscher" <stevenb.gcc@gmail.com>
>
> > On Dec 14, 2007 2:57 AM, Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote:
> > > > Date: Tue, 4 Dec 2007 19:13:35 -0400
> > > > From: Aldy Hernandez <aldyh@redhat.com>
> > >
> > > > > Anyway, the point of this communication: was it really a good
> > > > > thing to remove all test-cases using -fforce-addr? Why not just
> > > > > remove their -fforce-addr argument? Can we add them back?
> > > >
> > > > I don't have a problem with that. Steven?
> > >
> > > Any news on this?
> >
> > IMHO without -fforce-addr the test cases test nothing that isn't
> > already triggered by a gcc build or by another test case. I see no
> > point in keeping aruond test cases that add no test coverage.
>
> You're quick with your dismissals. When removing -fforce-addr,
> code was changed that at least formerly was exercised by the
> test-cases. As a result of that change, the generated code
> changed, so without further analysis (as to whether the
> execution path now actually is exercised by *these* tests),
> keeping the test-cases trivially make sense. Agree?
No, not to me.
But to be honest, I don't want to even be in this typical bikeshed gcc
discussion. If you feel so strongly about this, why don't you just
restore the test cases?
Gr.
Steven
next prev parent reply other threads:[~2007-12-14 13:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 21:35 Aldy Hernandez
2007-11-30 0:28 ` Richard Guenther
2007-12-03 23:18 ` PR33713: remove -fforce-addr (changes.html patch) Aldy Hernandez
2007-12-03 23:29 ` Gerald Pfeifer
2007-11-30 8:09 ` PR33713: remove -fforce-addr Michael Meissner
2007-11-30 11:49 ` Paolo Bonzini
2007-11-30 12:52 ` Steven Bosscher
2007-11-30 15:05 ` Richard Guenther
2007-11-30 18:17 ` Steven Bosscher
2007-12-03 23:11 ` Aldy Hernandez
2007-12-02 11:31 ` Hans-Peter Nilsson
[not found] ` <200712041513.lB4FDJle014800@ignucius.se.axis.com>
2007-12-04 15:19 ` Aldy Hernandez
2007-12-04 22:53 ` Hans-Peter Nilsson
2007-12-04 23:13 ` Aldy Hernandez
2007-12-14 2:06 ` Hans-Peter Nilsson
2007-12-14 7:59 ` Steven Bosscher
2007-12-14 12:02 ` Hans-Peter Nilsson
2007-12-14 13:32 ` Steven Bosscher [this message]
2007-12-07 16:18 ` Rask Ingemann Lambertsen
2007-12-07 16:48 ` Aldy Hernandez
2007-12-07 17:14 ` DJ Delorie
2007-12-07 17:17 ` Rask Ingemann Lambertsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571f6b510712140528ib0a1ca8m74567b8cc19d8403@mail.gmail.com \
--to=stevenb.gcc@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).