From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27513 invoked by alias); 14 Dec 2007 13:28:41 -0000 Received: (qmail 27502 invoked by uid 22791); 14 Dec 2007 13:28:40 -0000 X-Spam-Check-By: sourceware.org Received: from nz-out-0506.google.com (HELO nz-out-0506.google.com) (64.233.162.239) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Dec 2007 13:28:31 +0000 Received: by nz-out-0506.google.com with SMTP id i11so662751nzh.26 for ; Fri, 14 Dec 2007 05:28:29 -0800 (PST) Received: by 10.142.139.19 with SMTP id m19mr1426928wfd.7.1197638908044; Fri, 14 Dec 2007 05:28:28 -0800 (PST) Received: by 10.143.44.8 with HTTP; Fri, 14 Dec 2007 05:28:27 -0800 (PST) Message-ID: <571f6b510712140528ib0a1ca8m74567b8cc19d8403@mail.gmail.com> Date: Fri, 14 Dec 2007 13:32:00 -0000 From: "Steven Bosscher" To: "Hans-Peter Nilsson" Subject: Re: PR33713: remove -fforce-addr Cc: aldyh@redhat.com, gcc-patches@gcc.gnu.org In-Reply-To: <200712141151.lBEBpnP7011641@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <571f6b510712132325u2db2bf35g32152a11ea8049b4@mail.gmail.com> <200712141151.lBEBpnP7011641@ignucius.se.axis.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00661.txt.bz2 On Dec 14, 2007 12:51 PM, Hans-Peter Nilsson wrote: > > Date: Fri, 14 Dec 2007 08:25:11 +0100 > > From: "Steven Bosscher" > > > On Dec 14, 2007 2:57 AM, Hans-Peter Nilsson wrote: > > > > Date: Tue, 4 Dec 2007 19:13:35 -0400 > > > > From: Aldy Hernandez > > > > > > > > Anyway, the point of this communication: was it really a good > > > > > thing to remove all test-cases using -fforce-addr? Why not just > > > > > remove their -fforce-addr argument? Can we add them back? > > > > > > > > I don't have a problem with that. Steven? > > > > > > Any news on this? > > > > IMHO without -fforce-addr the test cases test nothing that isn't > > already triggered by a gcc build or by another test case. I see no > > point in keeping aruond test cases that add no test coverage. > > You're quick with your dismissals. When removing -fforce-addr, > code was changed that at least formerly was exercised by the > test-cases. As a result of that change, the generated code > changed, so without further analysis (as to whether the > execution path now actually is exercised by *these* tests), > keeping the test-cases trivially make sense. Agree? No, not to me. But to be honest, I don't want to even be in this typical bikeshed gcc discussion. If you feel so strongly about this, why don't you just restore the test cases? Gr. Steven