public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Steven Bosscher" <stevenb.gcc@gmail.com>
To: "Park, Seongbae" <seongbae.park@gmail.com>,
	 	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] proper dataflow block visitation order
Date: Sat, 09 Feb 2008 13:44:00 -0000	[thread overview]
Message-ID: <571f6b510802090108k75e386e0kceca1707538ca1a1@mail.gmail.com> (raw)

xf. http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00269.html

Seongbae wrote:
> +
> +  /* Make them reverse postorder.  */
> +  reverse_array (this_df->n_blocks, this_df->postorder);
> +  reverse_array (this_df->n_blocks, this_df->postorder_inverted);
> +}

Could you also change the names, then, to df->reverse_postorder and
df->reverse_postorder_inverted? This is going to confuse the heck out
of people who want to use these for their own purposes.

Maybe you can use pre_and_rev_post_order_compute() for df->postorder,
instead of computing postorder and reverting it with reverse_array().

And actually, what is wrong with just walking these arrays from the
last element to the first, instead of using reverse_array()?

> -  gcc_assert (dir != DF_NONE);
> -

Why are you removing this assert?

Gr.
Steven

             reply	other threads:[~2008-02-09  9:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 13:44 Steven Bosscher [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-02-10  0:09 Bradley Lucier
2008-02-09  1:26 Seongbae Park (박성배, 朴成培)
2008-02-09  3:40 ` Kenneth Zadeck
2008-02-09 14:11 ` Paolo Bonzini
2008-02-09 16:07   ` Kenneth Zadeck
2008-02-09 16:11     ` Paolo Bonzini
2008-02-09 16:15       ` Kenneth Zadeck
2008-02-09 16:22         ` Paolo Bonzini
2008-02-09 16:39           ` Kenneth Zadeck
2008-02-10 22:36             ` Richard Guenther
2008-02-11  7:06               ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571f6b510802090108k75e386e0kceca1707538ca1a1@mail.gmail.com \
    --to=stevenb.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=seongbae.park@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).