From: "Dominique d'Humières" <dominiq@lps.ens.fr>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Torvald Riegel <triegel@redhat.com>,
libstdc++@gcc.gnu.org,
gcc-patches <gcc-patches@gcc.gnu.org>,
Jack Howarth <howarth@bromo.med.uc.edu>
Subject: Re: [PATCH v2] libstdc++: Make certain exceptions transaction_safe.
Date: Thu, 21 Jan 2016 10:00:00 -0000 [thread overview]
Message-ID: <572007D4-C174-4181-8CE9-88D930581163@lps.ens.fr> (raw)
In-Reply-To: <20160119192001.GK15084@redhat.com>
Torvald,
Now that I can bootstrap on darwin, I have found the following failure for libitm.c++/libstdc++-safeexc.C
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::underflow_error::underflow_error(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::overflow_error::overflow_error(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::range_error::range_error(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::runtime_error::runtime_error(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::out_of_range::out_of_range(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::length_error::length_error(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::invalid_argument::invalid_argument(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::domain_error::domain_error(const string&)' within atomic transaction
throw T (what);
^~~~~
/opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: unsafe function call 'std::logic_error::logic_error(const string&)' within atomic transaction
throw T (what);
^~~~~
TIA
Dominique
> Le 19 janv. 2016 à 20:20, Jonathan Wakely <jwakely@redhat.com> a écrit :
>
> On 19/01/16 20:10 +0100, Torvald Riegel wrote:
>> On Sat, 2016-01-16 at 10:57 +0100, Dominique d'Humières wrote:
>>> > Addressed these, fixed a problem with using GLIBCXX_WEAK_DEFINITION
>>> > (which is only set on Darwin despite the generic-sounding name -- so
>>> > just use __attribute__((weak)) directly), and also updated
>>> > testsuite_abi.cc so that it knows about CXXABI_1.3.10.
>>> >
>>> > Approved by Jonathan Wakely. Committed as r232454.
>>> This breaks bootstrap on darwin, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69310.
>>
>> Please give this patch a try. I've only tested it on x86_64-linux.
>> Jon, okay from your side if Darwin testing succeeds?
>
> Yes, OK.
next prev parent reply other threads:[~2016-01-21 10:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 9:57 Dominique d'Humières
2016-01-16 20:05 ` Torvald Riegel
2016-01-19 19:10 ` Torvald Riegel
2016-01-19 19:20 ` Jonathan Wakely
2016-01-21 10:00 ` Dominique d'Humières [this message]
2016-01-21 14:00 ` Torvald Riegel
2016-01-21 15:25 ` Torvald Riegel
2016-01-21 17:15 ` Dominique d'Humières
2016-01-21 17:29 ` Dominique d'Humières
2016-01-21 18:09 ` Mike Stump
2016-01-21 18:12 ` Pedro Alves
2016-01-21 18:18 ` Torvald Riegel
2016-01-21 18:15 ` [PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX Torvald Riegel
2016-01-21 18:22 ` Mike Stump
2016-01-21 18:26 ` Jonathan Wakely
2016-01-21 18:27 ` Torvald Riegel
-- strict thread matches above, loose matches on Subject: below --
2016-01-16 12:16 [PATCH v2] libstdc++: Make certain exceptions transaction_safe David Edelsohn
2016-01-16 12:43 ` Jonathan Wakely
2016-01-16 12:47 ` David Edelsohn
2016-01-16 13:35 ` Jakub Jelinek
2016-01-16 13:41 ` Jonathan Wakely
2016-01-16 13:51 ` Jonathan Wakely
2016-01-16 20:12 ` Torvald Riegel
2016-01-16 20:24 ` David Edelsohn
2016-01-16 20:38 ` David Edelsohn
2016-01-17 20:21 ` Torvald Riegel
2016-01-17 20:32 ` Jakub Jelinek
2016-01-17 23:30 ` David Edelsohn
2016-01-18 13:54 ` Torvald Riegel
2016-01-18 16:30 ` Torvald Riegel
2016-01-18 20:08 ` Jonathan Wakely
2016-01-07 16:47 Torvald Riegel
2016-01-14 17:58 ` Jonathan Wakely
2016-01-15 22:44 ` Torvald Riegel
2016-01-16 22:58 ` H.J. Lu
2016-01-17 16:59 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572007D4-C174-4181-8CE9-88D930581163@lps.ens.fr \
--to=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=howarth@bromo.med.uc.edu \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).