From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125904 invoked by alias); 21 Jan 2016 10:00:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125879 invoked by uid 89); 21 Jan 2016 10:00:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:mailhos, H*RU:sk:mailhos, tia, H*r:sk:mailhos X-Spam-User: qpsmtpd, 2 recipients X-HELO: nef2.ens.fr Received: from nef2.ens.fr (HELO nef2.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jan 2016 10:00:15 +0000 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id u0LA0A57022314 ; Thu, 21 Jan 2016 11:00:10 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id 8317B158; Thu, 21 Jan 2016 11:00:10 +0100 (CET) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sjmfB2eleO8Q; Thu, 21 Jan 2016 11:00:10 +0100 (CET) Received: from [192.168.1.11] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10]) by mailhost.lps.ens.fr (Postfix) with ESMTPSA id 42EB4157; Thu, 21 Jan 2016 11:00:10 +0100 (CET) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: [PATCH v2] libstdc++: Make certain exceptions transaction_safe. From: =?iso-8859-1?Q?Dominique_d=27Humi=E8res?= In-Reply-To: <20160119192001.GK15084@redhat.com> Date: Thu, 21 Jan 2016 10:00:00 -0000 Cc: Torvald Riegel , libstdc++@gcc.gnu.org, gcc-patches , Jack Howarth Content-Transfer-Encoding: quoted-printable Message-Id: <572007D4-C174-4181-8CE9-88D930581163@lps.ens.fr> References: <1EF9008F-5418-4A35-AA1F-9931E464B0AA@lps.ens.fr> <1453230646.23593.13.camel@localhost.localdomain> <20160119192001.GK15084@redhat.com> To: Jonathan Wakely X-SW-Source: 2016-01/txt/msg01606.txt.bz2 Torvald, Now that I can bootstrap on darwin, I have found the following failure for = libitm.c++/libstdc++-safeexc.C /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::underflow_error::underflow_error(const string&)'= within atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::overflow_error::overflow_error(const string&)' w= ithin atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::range_error::range_error(const string&)' within = atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::runtime_error::runtime_error(const string&)' wit= hin atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::out_of_range::out_of_range(const string&)' withi= n atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::length_error::length_error(const string&)' withi= n atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::invalid_argument::invalid_argument(const string&= )' within atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::domain_error::domain_error(const string&)' withi= n atomic transaction throw T (what); ^~~~~ /opt/gcc/work/libitm/testsuite/libitm.c++/libstdc++-safeexc.C:50:2: error: = unsafe function call 'std::logic_error::logic_error(const string&)' within = atomic transaction throw T (what); ^~~~~ TIA Dominique > Le 19 janv. 2016 =E0 20:20, Jonathan Wakely a =E9cri= t : >=20 > On 19/01/16 20:10 +0100, Torvald Riegel wrote: >> On Sat, 2016-01-16 at 10:57 +0100, Dominique d'Humi=E8res wrote: >>> > Addressed these, fixed a problem with using GLIBCXX_WEAK_DEFINITION >>> > (which is only set on Darwin despite the generic-sounding name -- so >>> > just use __attribute__((weak)) directly), and also updated >>> > testsuite_abi.cc so that it knows about CXXABI_1.3.10. >>> > >>> > Approved by Jonathan Wakely. Committed as r232454. >>> This breaks bootstrap on darwin, see https://gcc.gnu.org/bugzilla/show_= bug.cgi?id=3D69310. >>=20 >> Please give this patch a try. I've only tested it on x86_64-linux. >> Jon, okay from your side if Darwin testing succeeds? >=20 > Yes, OK.