From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31882 invoked by alias); 27 Apr 2016 16:26:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31868 invoked by uid 89); 27 Apr 2016 16:26:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=duwe, Duwe, Hx-languages-length:1295 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Apr 2016 16:26:17 +0000 Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1lrp0014.outbound.protection.outlook.com [213.199.154.14]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-62-TOMpav8zTFqza5LmNpUXWQ-1; Wed, 27 Apr 2016 17:26:11 +0100 Received: from [10.2.206.73] (217.140.96.140) by VI1PR08MB1101.eurprd08.prod.outlook.com (10.166.45.20) with Microsoft SMTP Server (TLS) id 15.1.477.8; Wed, 27 Apr 2016 16:26:09 +0000 Message-ID: <5720E81D.9060409@arm.com> Date: Wed, 27 Apr 2016 16:26:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Torsten Duwe , Maxim Kuvyrkov CC: , Li Bin , Jiri Kosina , , Marcus Shawcroft , Takahiro Akashi Subject: Re: [PATCH] add -fprolog-pad=N option to c-family References: <20160427152217.GA2637@suse.de> In-Reply-To: <20160427152217.GA2637@suse.de> X-ClientProxiedBy: AM3PR08CA0020.eurprd08.prod.outlook.com (10.160.207.158) To VI1PR08MB1101.eurprd08.prod.outlook.com (10.166.45.20) X-MS-Office365-Filtering-Correlation-Id: c3a5781b-f0ab-40be-3f44-08d36eb8a443 X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB1101;2:5cEE/kCA5b0Ics1won0EGX15iPND822YhFvwK4mPsE6zDfkmNGvF1FdZmyIt30QxTSi9Y4Y8NED7mLYUaLdUf20wuc0yy3jB+FD2DDsyvEnapBnfvxJ0QrLyevHQGR/6QODm4oG/XOGxSrDnO+6L+KdmQcjXqPXnoSBz1zi6NrZIIE5eqK9By2uJgg3onHHz;3:xH5CWEMxfvWDjSItOUMAobuexTgGn+vvDblG8aAFECYVwvQGjeM66zbqSIMsl6iruBB9AqLdtIThQl6xOSx38j5eq5byxUM/sasprFB+tr7UwJHu9y+lqCtm3nR/mBAM;25:Hv5TSaq2tGkL8wtWNhi6iq2JQD35fWzhy+g8FyBzYKSUlTD+qKqwIDzkYixnpHavrQksn3L+b4v0y3i/jgdJPS61PxD26yNxKU3bUZLSzAqKqIzBVaCUf7ReWzg34j/PL77hkZ63cTEShfD5Qukhy3tEYbPpLV/fI9zc7lR3Ae/2CHbGxr43Sz+tOTqWCuUSNH/rexlbLohfR9V4dTX9sETs7UaWbIucBesEsarlNMoVIp2ZOoA/fnX2y2It856A09cEPJZGZXoxD80KsbtnZGyOYo6v1pUhW715j72O4zhL7oa98vimbptB4x9FgSk7NtHCnE1JPmVoOzxNgO5GfQ==;20:KFMkxd2FSXta9Kqq5zJqHWzJ06CJRNJfLkWpKjBvdeSvwAINU0NslKtXQIZtXXZumBnG/fRtnrst4OKghSzLmegnY7eNVHrTfsluOjmLeQFYidt+7pSkgHMjrVU544NBChchjWnsJUAR9E6WeCNdRDSAuPaQOEG4FzKHkp9qRPA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB1101; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:VI1PR08MB1101;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB1101; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB1101;4:AElLEq6IZF+qGWBUZD5j+A3m62rMa0YnGw8gfCTLmweF12RfyqCxty1eD0ZzHEw5M6jOU6Hi65lk0IP59tvBJPUu1LYpM2o5gtw2Iag7847g+SUguCIwX9oqBEgbBr5wgxhsWvYbtw8VStRllJvu1GDoHNclXHNm0BbYkl3lD4v3GM6eqOydk+Q3ajh8A4AMEp+MPflbRlup2iTDSwlwRZ/qYGwdvzCNWGTQ0o5mbVOaj9w+9nEC0PqAqDtXcLcRm2VGz5bfscUdL9n3RGk5OCIDZpzeDdhOqAWa3AtCrOhkk1OCZU7uNUEME02ou+/NxJYEIRXuX6oPCxQuEzpn68wDUoyMXiqeVUA9CJ0VeD+rEfBl4ga++REmqh4MyZhOFZekup1ubxw6uoGr521iRs/V5urhJD983pBe+cjDhaI= X-Forefront-PRVS: 0925081676 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(24454002)(189998001)(5004730100002)(81166005)(42186005)(4326007)(4001350100001)(33656002)(586003)(23746002)(64126003)(6116002)(2906002)(3846002)(230700001)(83506001)(80316001)(19580395003)(66066001)(65806001)(50986999)(77096005)(65956001)(47776003)(76176999)(5008740100001)(54356999)(87266999)(36756003)(2950100001)(1096002)(5001770100001)(92566002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB1101;H:[10.2.206.73];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR08MB1101;23:ePJ1C4eKnjH3CFnEqPYrUZl7uwa0zA981p4Sq?= =?Windows-1252?Q?xF5LB/8JGfIj4aAXtXYfDwR9fdwSCkS0Tv/XPcsn79OYKIJkmpySmyDg?= =?Windows-1252?Q?iWyLaGBHQmn9ZDy8JxZR6mc+KLKoPyOudWTrFY14PyPPSriyp1x+IhMQ?= =?Windows-1252?Q?Zt0apXXcWiL2swjSudDRWD/ozw7bzDYaT4GdIhYEDMi2f2Tn/qsHo+Gd?= =?Windows-1252?Q?D7zWM2qD98Tp0hQpaDQYIQTPQRqUTZIHJvvuK22dXHktUdw1uWGZDw/i?= =?Windows-1252?Q?fJD2cw3VbGoccCKCXli2rLte7MiFaL4pOSjvS6EBmt03mlhCo6FqTPrl?= =?Windows-1252?Q?qY9Dg4qS98+bErpjCZW/NbuwgTya+p3bKPWl1x8vwa4dTfNdbD694nt/?= =?Windows-1252?Q?/Hb99C0+jCTDWiMdOgYeRlQZbWCTUN0/kPu+nRFKZHPyjFkfyqw4Zj7Y?= =?Windows-1252?Q?aV+6NxlgQVIG+FFQaTi0UozjosjOTjuodOHNBp2Pf+LfTSFyy9BBezBI?= =?Windows-1252?Q?MGTF2JsncopF0R3EgTilRM8c4Mt8mcmQRzpwy9QyiNUxf1iNG+O5h49d?= =?Windows-1252?Q?GkpRy9g98WC+KjIdAid3VJVl+UeO0xowwoKY3w89cIC2VM8No0e2TrNo?= =?Windows-1252?Q?jFaQTOc7GyLljmv65zX+d+1qoNWpVaYIImm55Pm4X6UHnccv/JO6ECBb?= =?Windows-1252?Q?x/M9xmueN1r4PSjP8+Wxjf1n33xJnWt8A1oIvNr/z1Q6lb2JZnKwWCcO?= =?Windows-1252?Q?y3avcA6HxL+6YKIKr/tAbjZUsfohyJWVLbxmoSA0lDkAbfR+h4OcMMK+?= =?Windows-1252?Q?YleCPpz/P/d0FyK7rl963nppWkwCG9oPlXYTkmSSZJ2BaJuLrE/WPcuO?= =?Windows-1252?Q?GaYmaC4Y2af7O6ThAX8ym+J9bQmEVKJRPRSJglLwelOV0/Un8qfOrj7m?= =?Windows-1252?Q?O2SMDEZIVYAqYDACyfYa68LPtGqFXhocedXb2Q9OYZT4lruXn1RR93V6?= =?Windows-1252?Q?6hVVnIVbRXzzTyA96mlEMvxFLA70ff7+5Ocwy9IIg6CRpOrY2Coe4irK?= =?Windows-1252?Q?KVdOrFFKvUuekdgrt2C+CeNjx95BlR+IOpb?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB1101;5:NcElXIb9KY4xPBWicxD3APbyH8yFY8gvkCMD92yevnLQmylJujeOePcyVdvG01HL1Vy6CCIzyixYriJ0iHt2eMvOTV2V7ujcDiyIE2mef0hqIiuJzp8VzPNgaztTLEQ/1AHRwmHMc3GRPDTEIzjPdA==;24:5LWQGO39qtuIxHRRR+gIT0PyNeZCEDNBKngmJnLtdLmygl5/E80QGFjKPVhvEalTZcIYgdgclg0d8DAlIUE9ZjmlyzGdglLQOP1w/SQcUmQ=;7:jO8Q/eX5sGjj+xIE9G+vH089iDBqAAgR95PHRHzCP8bOE6igXkp4sX2XWChq3fgQbkGxjstTDdSHlBT211ENRX+pSnSWovZvmvHR6r3VGUh0Us7a0NAUJq3RUfDn9/IGfq1HgmXRnKpa6gU1qwfEF69HJdeJbrYMAoWGjB8oHzwz7vKFjR90llbpmahbhfwH;20:tZPmE0UYDw9hfJvaOXliOryTH3SfzXJdB4AykoijiGrtudL48mrKiCU5WL62iOdHWpvUjTG27y73nTyqBWQ14qJmV3/XErb8jIWHgS/9yvUFPDQS61z2j7zQW/PDD7km+HEMDpSy3+LIOJJ3sk/c2qoM0jMHUzw5OyAcYzCqeeQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2016 16:26:09.4373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB1101 X-MC-Unique: TOMpav8zTFqza5LmNpUXWQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg01691.txt.bz2 On 27/04/16 16:22, Torsten Duwe wrote: > Hi Maxim, >=20 > thanks for starting the work on this; I have added the missing > command line option. It builds now and the resulting compiler generates > a linux kernel with the desired properties, so work can continue there. >=20 > Torsten i guess the flag should be documented in invoke.texi it's not clear what N means in -fprolog-pad=3DN, how location recording is enabled and how it interacts with -fipa-ra. (-pg disables -fipa-ra, but -fprolog-pad works without -pg.) with -mfentry, by default the user only has to implement the fentry call (linux wants nops there, but e.g. glibc could use -pg -mfentry for profiling on aarch64 and the target specific details are easier to document for an -m option than for something general). the nop-padding is more general, but the size and layout of nops and the call abi will be target specific and the user will most likely need to modify the binary (to get the right sequence) which needs additional tooling. i don't know who might use it other than linux (which already has tools to deal with -mfentry). i'm not against nop-padding, but i think more evidence is needed that the generalization is a good idea and users can deal with the resulting issues.