From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112947 invoked by alias); 28 Apr 2016 11:47:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112857 invoked by uid 89); 28 Apr 2016 11:47:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: mailrelay1.public.one.com Received: from mailrelay1.public.one.com (HELO mailrelay1.public.one.com) (91.198.169.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Apr 2016 11:47:34 +0000 X-HalOne-Cookie: cdc3516b7e04863f21b128e2e059ca8b9659b8d3 X-HalOne-ID: fb0cd28e-0d36-11e6-a8e4-b8ca3afa9d73 Received: from localhost.localdomain (unknown [91.135.11.213]) by smtpfilter1.public.one.com (Halon Mail Gateway) with ESMTPSA; Thu, 28 Apr 2016 11:47:25 +0000 (UTC) Subject: Re: [PATCH 5/6] [ARC] Fix unwanted match for sign extend 16-bit constant. To: Claudiu Zissulescu , gcc-patches@gcc.gnu.org References: <1460990028-5718-1-git-send-email-claziss@synopsys.com> <1460990028-5718-6-git-send-email-claziss@synopsys.com> Cc: Francois.Bedard@synopsys.com, jeremy.bennett@embecosm.com From: Joern Wolfgang Rennecke Message-ID: <5721F84D.2090002@amylaar.uk> Date: Thu, 28 Apr 2016 11:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1460990028-5718-6-git-send-email-claziss@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg01805.txt.bz2 On 18/04/16 15:33, Claudiu Zissulescu wrote: > The combine pass may conclude umulhisi3_imm pattern can accept also sign > extended 16-bit constants. This patch prohibits the combine in considering > this pattern as suitable. > > OK to apply? > Claudiu > > gcc/ > 2016-04-18 Claudiu Zissulescu > > * config/arc/arc.md (umulhisi3_imm): Avoid unwanted match for sign > extend 16-bit constants. ... > * testsuite/gcc.target/arc/umulsihi3_z.c: New file. > - (match_operand:HI 2 "short_const_int_operand" " L, L,I,C16,C16")))] > + (match_operand:HI 2 "short_const_int_operand" " L, L,I,C16,C16"))) > + (use (match_dup 2))] > That's not the way to fix it. Get the predicates and constraints right.