From: Joern Wolfgang Rennecke <gnu@amylaar.uk>
To: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
gcc-patches@gcc.gnu.org
Cc: Francois.Bedard@synopsys.com, jeremy.bennett@embecosm.com
Subject: Re: [PATCH] [ARC] Add new ARCv2 instructions.
Date: Thu, 28 Apr 2016 15:20:00 -0000 [thread overview]
Message-ID: <57222A12.20909@amylaar.uk> (raw)
In-Reply-To: <1461154325-8024-1-git-send-email-claziss@synopsys.com>
On 20/04/16 13:12, Claudiu Zissulescu wrote:
> This patch adds new instruction variants as introduced by the ARCv2
> architecture.
>
>
You have used groups of 8 spaces at line starts; tabs should be used
instead for indentation.
> (arc_dwarf_register_span): Remove enum keyword.
That bit should be separate.
> (compact_memory_operand_p): New function.
The description of the arguments in the start-of-function comment
does not agree with how the arguments are used in the definition of the
"UTS" .
Moreover, it says:
CODE_DENSITY indicates ARCv2 code density operations are
+ available
which implies that these are additional opcodes that are available, yet for the
base+index register case, we have:
+ {
+ return !code_density;
+ }
Considering this comment:
+ /* Reverting for the moment since ld/st{w,h}_s does not have sp
+ as a valid parameter. */
The historical context is utterly lost, so the "Reverting for the moment since"
bit only confuses.
next prev parent reply other threads:[~2016-04-28 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 12:13 Claudiu Zissulescu
2016-04-28 15:20 ` Joern Wolfgang Rennecke [this message]
2016-04-29 14:22 ` Claudiu Zissulescu
2016-04-29 16:19 ` Joern Wolfgang Rennecke
2016-04-29 14:24 ` Claudiu Zissulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57222A12.20909@amylaar.uk \
--to=gnu@amylaar.uk \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeremy.bennett@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).