From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103842 invoked by alias); 28 Apr 2016 15:20:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103823 invoked by uid 89); 28 Apr 2016 15:20:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=wh, spaces X-HELO: mailrelay7.public.one.com Received: from mailrelay7.public.one.com (HELO mailrelay7.public.one.com) (91.198.169.215) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Apr 2016 15:19:53 +0000 X-HalOne-Cookie: 5ca083474a704ec63680cfb78e37eaf4df9fa7f0 X-HalOne-ID: a51b0129-0d54-11e6-bb5b-b82a72cffc46 Received: from localhost.localdomain (unknown [91.135.11.213]) by smtpfilter4.public.one.com (Halon Mail Gateway) with ESMTPSA; Thu, 28 Apr 2016 15:19:47 +0000 (UTC) Subject: Re: [PATCH] [ARC] Add new ARCv2 instructions. To: Claudiu Zissulescu , gcc-patches@gcc.gnu.org References: <1461154325-8024-1-git-send-email-claziss@synopsys.com> Cc: Francois.Bedard@synopsys.com, jeremy.bennett@embecosm.com From: Joern Wolfgang Rennecke Message-ID: <57222A12.20909@amylaar.uk> Date: Thu, 28 Apr 2016 15:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1461154325-8024-1-git-send-email-claziss@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg01848.txt.bz2 On 20/04/16 13:12, Claudiu Zissulescu wrote: > This patch adds new instruction variants as introduced by the ARCv2 > architecture. > > You have used groups of 8 spaces at line starts; tabs should be used instead for indentation. > (arc_dwarf_register_span): Remove enum keyword. That bit should be separate. > (compact_memory_operand_p): New function. The description of the arguments in the start-of-function comment does not agree with how the arguments are used in the definition of the "UTS" . Moreover, it says: CODE_DENSITY indicates ARCv2 code density operations are + available which implies that these are additional opcodes that are available, yet for the base+index register case, we have: + { + return !code_density; + } Considering this comment: + /* Reverting for the moment since ld/st{w,h}_s does not have sp + as a valid parameter. */ The historical context is utterly lost, so the "Reverting for the moment since" bit only confuses.