From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42404 invoked by alias); 29 Apr 2016 20:04:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42394 invoked by uid 89); 29 Apr 2016 20:04:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=msg X-HELO: mail-qg0-f48.google.com Received: from mail-qg0-f48.google.com (HELO mail-qg0-f48.google.com) (209.85.192.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 Apr 2016 20:04:17 +0000 Received: by mail-qg0-f48.google.com with SMTP id f74so47364801qge.2 for ; Fri, 29 Apr 2016 13:04:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Zm0PpCO9U4l8+1zIH5gqFWznCfjnRbl0EF/dIT9s+v8=; b=kmU1evC0EScD4qOYYdAW8tgpRCpKtt3Y3ZyhpXLpBmW5TdMq2b7JTNKHz75u/iIiLW eGdNaM1Zd6odQbQcVHvxHprJzyUkImB7RZ4iLNuLDrYXemlk2H++00Nh0tpRonbFV7lm bXltdkAZIbhGuPp9+sP+foazZycrx4BfXHOB/ajLouq/QUk5HZXUt1Pq0VhGIB+UiNtZ B5qLhGb/WgTwgbkp++slIYnPtBYgOhWbO58PWijo9qfjsfT4ODtZNACvigUKvtoQdgPb CtXmtPcAhT4lP0y8TFg3p8NVIxcvyQKd0vQxe6b+vAzjcMQozpR757zcLQtSr4yQbcX9 W5Ww== X-Gm-Message-State: AOPr4FVTgmw01ovXhZ67n4T0sINBTX1IJGjYWR0+GZzmJNMYzXr+dGEF4HS5FiBnR1XCCusE X-Received: by 10.140.28.135 with SMTP id 7mr21015461qgz.72.1461960255114; Fri, 29 Apr 2016 13:04:15 -0700 (PDT) Received: from [192.168.1.50] (209-6-90-240.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com. [209.6.90.240]) by smtp.gmail.com with ESMTPSA id j19sm4977199qke.22.2016.04.29.13.04.14 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Apr 2016 13:04:14 -0700 (PDT) Subject: Re: [PATCH] Better location info for "incomplete type" error msg (PR c/70756) To: Marek Polacek , GCC Patches References: <20160428155908.GQ28445@redhat.com> From: Jason Merrill Message-ID: <5723BE3D.4070706@redhat.com> Date: Fri, 29 Apr 2016 20:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160428155908.GQ28445@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg02055.txt.bz2 On 04/28/2016 11:59 AM, Marek Polacek wrote: > 3) for the C++ FE I used a macro so that I don't have to change all the > cxx_incomplete_type_error calls now, How about an inline overload, instead? It seems sad to discard the location information; could we pass it into cxx_incomplete_type_diagnostic? Jason