From: Bernd Schmidt <bschmidt@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Oleg Endo <oleg.endo@t-online.de>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
Dominik Vogt <vogt@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fix spec-options.c test case
Date: Mon, 02 May 2016 10:26:00 -0000 [thread overview]
Message-ID: <57272B41.8080703@redhat.com> (raw)
In-Reply-To: <AM4PR07MB1571BF44DAAEA78762C2F494E4780@AM4PR07MB1571.eurprd07.prod.outlook.com>
On 05/01/2016 09:52 AM, Bernd Edlinger wrote:
> Hi,
>
> I took a closer look at this test case, and I found, except that
> it triggers a dejagnu bug, it is also wrong. I have tested with
> a cross-compiler for target=sh-elf and found that the test case
> actually FAILs because the foo.specs uses "cppruntime" which
> is only referenced in gcc/config/sh/superh.h, but sh/superh.h
> is only included for target sh*-superh-elf, see gcc/config.gcc.
>
> This means that it can only pass for target=sh-superh-elf.
>
> The attached patch fixes the testcase and makes it run always,
> so that it does no longer triggers the dejagnu bug.
So, two things. Why not use a string in the specs file that exists on
all targets? If it's a sh-specific thing we want to test, move why not
move it to gcc.target?
Bernd
next prev parent reply other threads:[~2016-05-02 10:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 7:53 Bernd Edlinger
2016-05-02 8:31 ` Dominik Vogt
2016-05-02 10:26 ` Bernd Schmidt [this message]
2016-05-02 13:43 ` Bernd Edlinger
2016-05-02 14:13 ` Bernd Schmidt
2016-05-02 21:28 ` Oleg Endo
2016-05-03 0:05 ` Bernd Edlinger
2016-05-03 1:30 ` [gcc] " Kaz Kojima
2016-05-03 1:19 ` Kaz Kojima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57272B41.8080703@redhat.com \
--to=bschmidt@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
--cc=oleg.endo@t-online.de \
--cc=vogt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).