public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Julian Brown <julian@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>,
	<Thomas_Schwinge@mentor.com>, <fortran@gcc.gnu.org>
Subject: Re: [PATCH] OpenACC: whole struct vs. component mappings (PR107028)
Date: Thu, 29 Sep 2022 15:09:26 +0200	[thread overview]
Message-ID: <573279e5-11fa-85de-51dd-292c63b0bd04@codesourcery.com> (raw)
In-Reply-To: <20220929135911.1b2ff3de@squid.athome>

On 29.09.22 14:59, Julian Brown wrote:
> On Wed, 28 Sep 2022 17:17:30 +0200 Tobias Burnus <tobias@codesourcery.com> wrote:
>> I don't see immediately whether some cases can still reach
>> omp_accumulate_sibling_list – if so, a testcase would be nice, or
>> whether that error_at can now be removed.
> This version of the patch removes the now-redundant check in
> omp_accumulate_sibling_list.
Thanks!
>> However, I note that *without* the patch, the *following* *error*
>> triggers – while it compiles *silently* *with* the *patch* applied:
>> [...]
> ...and this test now triggers an error again (as it should -- you can't
> map more than one part of the same array).
...
> Re-tested with offloading to NVPTX. OK?

LGTM.

Thanks for the patch!

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

      reply	other threads:[~2022-09-29 13:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 13:20 Julian Brown
     [not found] ` <66a6261f-cf6f-3a54-b928-eb86ffab4db7@codesourcery.com>
2022-09-29 12:59   ` Julian Brown
2022-09-29 13:09     ` Tobias Burnus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573279e5-11fa-85de-51dd-292c63b0bd04@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=Thomas_Schwinge@mentor.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=julian@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).