From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 667943858D39; Thu, 29 Sep 2022 13:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 667943858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,355,1654588800"; d="scan'208";a="83729804" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 29 Sep 2022 05:09:34 -0800 IronPort-SDR: xPwU+AwxSgY6Kzaq9A923dV3LkGjsSsBvFRIK7lMyyQa28nzRF4aUE1nyqO0B4XwouraMUMH8h /dr6Y7G7hAqWXNns1dsPLGB1b0ihhNpn/7++213rBbmxdVPFCLmAOWaKmj1kBsL38GdlWZOoDS zEr4jPFmHXEJyTQKkzXKVUTFGTDN5OUdzlEZVQIRsOvjNKBwBEPqTEXOl8gXY6iWtE9HcQyirQ NDXm6Jr4NW5EUVMy5ifnJ5Tes0eW9nvru+zCm+G0f0KiMfRJOfHTyaycd6NQAZmm4M8Su6diK2 h4w= Message-ID: <573279e5-11fa-85de-51dd-292c63b0bd04@codesourcery.com> Date: Thu, 29 Sep 2022 15:09:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] OpenACC: whole struct vs. component mappings (PR107028) Content-Language: en-US To: Julian Brown CC: , Jakub Jelinek , , References: <20220928132024.64984-1-julian@codesourcery.com> <66a6261f-cf6f-3a54-b928-eb86ffab4db7@codesourcery.com> <20220929135911.1b2ff3de@squid.athome> From: Tobias Burnus In-Reply-To: <20220929135911.1b2ff3de@squid.athome> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.09.22 14:59, Julian Brown wrote: > On Wed, 28 Sep 2022 17:17:30 +0200 Tobias Burnus wrote: >> I don't see immediately whether some cases can still reach >> omp_accumulate_sibling_list =E2=80=93 if so, a testcase would be nice, o= r >> whether that error_at can now be removed. > This version of the patch removes the now-redundant check in > omp_accumulate_sibling_list. Thanks! >> However, I note that *without* the patch, the *following* *error* >> triggers =E2=80=93 while it compiles *silently* *with* the *patch* appli= ed: >> [...] > ...and this test now triggers an error again (as it should -- you can't > map more than one part of the same array). ... > Re-tested with offloading to NVPTX. OK? LGTM. Thanks for the patch! Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955