From: "Martin Liška" <mliska@suse.cz>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH] libiberty: stop using PTR macro.
Date: Tue, 10 May 2022 16:03:27 +0200 [thread overview]
Message-ID: <5735520c-61fe-74ee-b947-ec3f12f94795@suse.cz> (raw)
In-Reply-To: <CAMfHzOte+jFOxb7NeV+wUrC+M6M68YE25MxeXtCDstZgu=qEbA@mail.gmail.com>
On 5/10/22 15:50, Eric Gallager wrote:
> Hi, please preserve existing style when possible when making this
> replacement; ISTR there are some tools (like for generating
> libiberty's documentation) that depend on the return type being on a
> separate line... If all of the relevant Makefile targets still work
> after this change, well, fine, but... well, just something to
> consider...
Hello.
Thanks for heads up. I make the replacement by a tool and wrongly forgot
to append a newline in some cases.
It's fixed in the installed version of the patch.
Martin
next prev parent reply other threads:[~2022-05-10 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 8:56 Martin Liška
2022-05-10 13:37 ` Jeff Law
2022-05-10 13:50 ` Eric Gallager
2022-05-10 14:03 ` Martin Liška [this message]
2022-05-10 14:20 ` Alan Modra
2022-05-10 15:33 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735520c-61fe-74ee-b947-ec3f12f94795@suse.cz \
--to=mliska@suse.cz \
--cc=amodra@gmail.com \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).