public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bschmidt@redhat.com>
To: Mikhail Maltsev <maltsevm@gmail.com>,
	       Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
	       gcc-patches <gcc-patches@gnu.org>,
	       Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH 2/2][GCC] Add one more pattern to RTL if-conversion
Date: Thu, 02 Jun 2016 09:33:00 -0000	[thread overview]
Message-ID: <574FFD60.7090109@redhat.com> (raw)
In-Reply-To: <57448DB4.60600@gmail.com>

On 05/24/2016 07:21 PM, Mikhail Maltsev wrote:

+           target = expand_simple_binop (mode, (diff < 0) ? MINUS : PLUS,

Parentheses around (diff < 0) aren't needed. Otherwise I think this is 
also OK.


Bernd

      reply	other threads:[~2016-06-02  9:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 13:53 [PATCH 0/2][GCC] " Mikhail Maltsev
2016-05-23 13:58 ` [PATCH 1/2][GCC] Refactor noce_try_store_flag_constants Mikhail Maltsev
2016-06-02  9:28   ` Bernd Schmidt
2016-05-23 14:00 ` [PATCH 2/2][GCC] Add one more pattern to RTL if-conversion Mikhail Maltsev
2016-05-23 14:15   ` Kyrill Tkachov
2016-05-24 19:06     ` Mikhail Maltsev
2016-06-02  9:33       ` Bernd Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574FFD60.7090109@redhat.com \
    --to=bschmidt@redhat.com \
    --cc=gcc-patches@gnu.org \
    --cc=kyrylo.tkachov@foss.arm.com \
    --cc=maltsevm@gmail.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).