From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89696 invoked by alias); 2 Jun 2016 12:26:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89680 invoked by uid 89); 2 Jun 2016 12:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:6020908, H*MI:sk:2016060 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jun 2016 12:26:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74B227AE91; Thu, 2 Jun 2016 12:26:31 +0000 (UTC) Received: from localhost.localdomain (vpn1-7-194.ams2.redhat.com [10.36.7.194]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u52CQTgf028827; Thu, 2 Jun 2016 08:26:29 -0400 Subject: Re: Fix up dg-set-compiler-env-var To: Jakub Jelinek , Dhole , Rainer Orth , Mike Stump References: <20160428103506.GM26501@tucnak.zalov.cz> <57220BC2.7080901@redhat.com> <20160428131420.GO26501@tucnak.zalov.cz> <20160428182956.GG21574@panther> <20160429071744.GX26501@tucnak.zalov.cz> <20160505232654.GW21574@panther> <5731C6B3.3070903@redhat.com> <20160512003651.GB17273@panther> <57344A09.7030901@redhat.com> <20160513170930.GN17273@panther> <20160602121905.GE28550@tucnak.redhat.com> Cc: Eduard Sanou , Matthias Klose , gcc-patches@gcc.gnu.org From: Bernd Schmidt Message-ID: <575025F4.6020908@redhat.com> Date: Thu, 02 Jun 2016 12:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160602121905.GE28550@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00156.txt.bz2 On 06/02/2016 02:19 PM, Jakub Jelinek wrote: > The problem is that in cleanup-after-saved-dg-test, there are missing global > directives, so when it tests/uses the set_compiler_env_var and > saved_compiler_env_var vars to see if it should call > restore-compiler-env-var, it uses local (non-existing) vars instead and > never restores the env var. I'm puzzled how failing to restore the env var causes a failure, but your patch is (obviously) ok. Bernd