From: Vladimir Makarov <vmakarov@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <rguenther@suse.de>, Jeff Law <law@redhat.com>
Subject: Re: [PING] [PATCH] Fix asm X constraint (PR inline-asm/59155)
Date: Mon, 06 Jun 2016 17:04:00 -0000 [thread overview]
Message-ID: <5755AD05.4010608@redhat.com> (raw)
In-Reply-To: <AM4PR07MB157148DEF55A9C540991A296E45C0@AM4PR07MB1571.eurprd07.prod.outlook.com>
On 06/06/2016 09:32 AM, Bernd Edlinger wrote:
> Ping...
>
> see https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02010.html
>
>
Thank you for working on the PR and sorry for the delay with LRA part of
review.
Change in lra-constraints.c is ok for me with the following change.
Instead of just
- curr_alt[nop] = NO_REGS;
+ curr_alt[nop] = ALL_REGS;
CLEAR_HARD_REG_SET (curr_alt_set[nop]);
I'd like to see
- curr_alt[nop] = NO_REGS;
+ curr_alt[nop] = ALL_REGS;
- CLEAR_HARD_REG_SET (curr_alt_set[nop]);
+ COPY_HARD_REG_SET (curr_alt_set[nop], reg_class_contents[ALL_REGS]);
Also I don't see /* { dg-do compile } */ in the tests (I don't know what dejagnu does when there is no any dejagnu actions in the test).
But with the addition '/* { dg-do compile } */' the test pr59155-2.c is ok for me too.
As for recog.c, I can not approve this as I am not a maintainer of it.
I only can say that the code looks questionable to me.
next prev parent reply other threads:[~2016-06-06 17:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:45 Bernd Edlinger
2016-06-06 13:33 ` [PING] " Bernd Edlinger
2016-06-06 17:04 ` Vladimir Makarov [this message]
2016-06-06 17:54 ` Jeff Law
2016-06-06 18:01 ` Jakub Jelinek
2016-06-06 18:04 ` Jeff Law
2016-06-06 18:09 ` Jakub Jelinek
2016-06-06 19:28 ` Marc Glisse
2016-06-06 19:40 ` Jakub Jelinek
2016-06-09 16:30 ` Jeff Law
2016-06-09 16:43 ` Jakub Jelinek
2016-06-09 16:45 ` Jakub Jelinek
2016-06-10 14:13 ` Bernd Edlinger
2016-06-19 13:25 ` [PING**2] " Bernd Edlinger
2016-06-22 19:51 ` Jeff Law
2016-06-22 20:49 ` Bernd Edlinger
2016-07-20 20:04 ` Jeff Law
2016-07-21 16:30 ` Bernd Edlinger
2016-08-04 20:27 ` Jeff Law
2016-08-05 13:30 ` Bernd Edlinger
2016-06-20 22:06 ` [PING] " Jeff Law
2016-06-21 1:52 ` Bernd Edlinger
2016-06-07 17:58 ` Bernd Edlinger
2016-06-09 16:28 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5755AD05.4010608@redhat.com \
--to=vmakarov@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).