From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49292 invoked by alias); 6 Jun 2016 17:04:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48682 invoked by uid 89); 6 Jun 2016 17:04:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:CLEAR_H, sk:clear_h X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 06 Jun 2016 17:04:09 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BEEE78F517; Mon, 6 Jun 2016 17:04:07 +0000 (UTC) Received: from [10.3.112.23] (ovpn-112-23.phx2.redhat.com [10.3.112.23]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u56H45si019047; Mon, 6 Jun 2016 13:04:06 -0400 Subject: Re: [PING] [PATCH] Fix asm X constraint (PR inline-asm/59155) To: Bernd Edlinger , "gcc-patches@gcc.gnu.org" References: Cc: Richard Biener , Jeff Law From: Vladimir Makarov Message-ID: <5755AD05.4010608@redhat.com> Date: Mon, 06 Jun 2016 17:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00408.txt.bz2 On 06/06/2016 09:32 AM, Bernd Edlinger wrote: > Ping... > > see https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02010.html > > Thank you for working on the PR and sorry for the delay with LRA part of review. Change in lra-constraints.c is ok for me with the following change. Instead of just - curr_alt[nop] = NO_REGS; + curr_alt[nop] = ALL_REGS; CLEAR_HARD_REG_SET (curr_alt_set[nop]); I'd like to see - curr_alt[nop] = NO_REGS; + curr_alt[nop] = ALL_REGS; - CLEAR_HARD_REG_SET (curr_alt_set[nop]); + COPY_HARD_REG_SET (curr_alt_set[nop], reg_class_contents[ALL_REGS]); Also I don't see /* { dg-do compile } */ in the tests (I don't know what dejagnu does when there is no any dejagnu actions in the test). But with the addition '/* { dg-do compile } */' the test pr59155-2.c is ok for me too. As for recog.c, I can not approve this as I am not a maintainer of it. I only can say that the code looks questionable to me.