From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113675 invoked by alias); 7 Jun 2016 08:22:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 113663 invoked by uid 89); 7 Jun 2016 08:22:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jun 2016 08:22:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAAC3F; Tue, 7 Jun 2016 01:22:41 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D28163F213; Tue, 7 Jun 2016 01:22:06 -0700 (PDT) Subject: Re: [PATCH][AArch64] Model CSEL instruction in Cortex-A57 scheduling model To: Kyrill Tkachov , GCC Patches References: <5755A061.1000909@foss.arm.com> Cc: Marcus Shawcroft , Richard Earnshaw , James Greenhalgh From: Ramana Radhakrishnan Message-ID: <5756842D.6010606@foss.arm.com> Date: Tue, 07 Jun 2016 08:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5755A061.1000909@foss.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00453.txt.bz2 On 06/06/16 17:10, Kyrill Tkachov wrote: > Hi all, > > This small patch adds handling of the CSEL-type instructions to the Cortex-A57 scheduling model. > It is treated the same as simple ALU instructions. > > With this patch I didn't see any overall differences in SPEC2006. > > Bootstrapped and tested on arm-none-linux-gnueabihf and aarch64-linux-gnu. > > Ok for trunk? > > The patch is very simple and the csel value isn't used in any arm instructions so I think > just an aarch64 approval for this should be enough. > > Thanks, > Kyrill > > 2016-06-06 Kyrylo Tkachov > > * config/arm/cortex-a57.md (cortex_a57_alu): > Handle csel type. This is ok by me - in these sorts of situations I think we should let the aarch64 approvals be sufficient. regards Ramana