From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: [PATCH][ARM] Delete thumb_reload_in_h
Date: Fri, 10 Jun 2016 14:55:00 -0000 [thread overview]
Message-ID: <575AD4D3.1030008@foss.arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
Hi all,
This function just ICEs and isn't actually called from anywhere.
It was introduced back in 2000 as part of a large merge introducing Thumb support
and was aborting even then. I don't think having it around is of any benefit.
Tested on arm-none-eabi.
Ok for trunk?
Thanks,
Kyrill
2016-06-10 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* config/arm/arm.c (thumb_reload_in_hi): Delete.
* config/arm/arm-protos.h (thumb_reload_in_hi): Delete prototype.
[-- Attachment #2: thumb_reload_in_hi.patch --]
[-- Type: text/x-patch, Size: 1227 bytes --]
diff --git a/gcc/config/arm/arm-protos.h b/gcc/config/arm/arm-protos.h
index b6981bcfb9070787cb7472b00c24e0f86a2cae1f..888aaf944a7974d61d96f356a94acefa8e9a2f21 100644
--- a/gcc/config/arm/arm-protos.h
+++ b/gcc/config/arm/arm-protos.h
@@ -193,7 +193,6 @@ extern const char *thumb_call_via_reg (rtx);
extern void thumb_expand_movmemqi (rtx *);
extern rtx arm_return_addr (int, rtx);
extern void thumb_reload_out_hi (rtx *);
-extern void thumb_reload_in_hi (rtx *);
extern void thumb_set_return_address (rtx, rtx);
extern const char *thumb1_output_casesi (rtx *);
extern const char *thumb2_output_casesi (rtx *);
diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 70e52546bc45c404788713c535e116e591ec5d4e..1618a1eaaa3a9902f45a15f3de5b524a4dfbebb8 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -25670,13 +25670,6 @@ thumb_reload_out_hi (rtx *operands)
emit_insn (gen_thumb_movhi_clobber (operands[0], operands[1], operands[2]));
}
-/* Handle reading a half-word from memory during reload. */
-void
-thumb_reload_in_hi (rtx *operands ATTRIBUTE_UNUSED)
-{
- gcc_unreachable ();
-}
-
/* Return the length of a function name prefix
that starts with the character 'c'. */
static int
next reply other threads:[~2016-06-10 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 14:55 Kyrill Tkachov [this message]
2016-06-17 14:38 ` Kyrill Tkachov
2016-06-30 17:24 ` Kyrill Tkachov
2016-07-01 9:00 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575AD4D3.1030008@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramana.radhakrishnan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).