From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126788 invoked by alias); 14 Jun 2016 18:46:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126776 invoked by uid 89); 14 Jun 2016 18:46:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=921, Hx-languages-length:1207, H*MI:sk:2016050 X-HELO: mailrelay7.public.one.com Received: from mailrelay7.public.one.com (HELO mailrelay7.public.one.com) (91.198.169.215) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 14 Jun 2016 18:46:38 +0000 X-HalOne-Cookie: d2c0cf1cd34522d166c774513cc1943109df2fbc X-HalOne-ID: 4f2c400f-3260-11e6-a0c6-b82a72cffc46 Received: from localhost.localdomain (unknown [91.135.11.213]) by smtpfilter4.public.one.com (Halon Mail Gateway) with ESMTPSA; Tue, 14 Jun 2016 18:46:30 +0000 (UTC) Subject: Re: [PATCHv2 0/7] ARC: Add support for nps400 variant To: Andrew Burgess , Claudiu Zissulescu References: <57222CCF.1090109@amylaar.uk> <57224071.1020905@amylaar.uk> <098ECE41A0A6114BB2A07F1EC238DE896618A1BF@de02wembxa.internal.synopsys.com> <20160429221713.GI1592@embecosm.com> <098ECE41A0A6114BB2A07F1EC238DE896618A44C@de02wembxa.internal.synopsys.com> <20160503105601.GB9646@embecosm.com> Cc: "gcc-patches@gcc.gnu.org" , "noamca@mellanox.com" From: Joern Wolfgang Rennecke Message-ID: <57605105.7050507@amylaar.uk> Date: Tue, 14 Jun 2016 18:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160503105601.GB9646@embecosm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg01068.txt.bz2 On 03/05/16 11:56, Andrew Burgess wrote: > * Claudiu Zissulescu [2016-05-02 09:02:16 +0000]: > >> Please also consider to address also the following warnings introduced: >> >> mainline/gcc/gcc/config/arc/arc.md:888: warning: source missing a mode? >> mainline/gcc/gcc/config/arc/arc.md:906: warning: source missing a mode? >> mainline/gcc/gcc/config/arc/arc.md:921: warning: source missing a mode? >> mainline/gcc/gcc/config/arc/arc.md:6146: warning: source missing a mode? >> > Here's a revised fixup patch that includes addressing these 4 > warnings. This the the wrong approach. zn_compare_operator is a special predicate that accepts CC_ZNmode as well as CC_Zmode. The point is that some comparison uses need Z and N set, while other are OK with just Z. Not accepting CC_Zmode would cause spurious recognition rejections. A generator program complaining about a missing mode for an operand with a special predicate is wrong. from md.texi: : Predicates written with @code{define_special_predicate} do not get any : automatic mode checks, and are treated as having special mode handling : by @command{genrecog}.