Re: Test Harness and SPARC VIS Instructions

Re: Test Harness and SPARC VIS Instructions

[Uros Bizjak]

Hello!

> This one looks like another test slipping another unsupported
> instruction by.
>
> 0x020012b8 <fbar+40>: bne,pn %icc, 0x200138c <fbar+252>
>
> Is this UltraSPARC and not V7?  Do we need two bad instructions
> in the test case?
>
> Executing on host: /home/joel/work-gnat/svn/b-gcc1-sparc/gcc/xgcc 
> -B/home/joel/work-gnat/svn/b-gcc1-sparc/gcc/ 
> /home/joel/work-gnat/svn/gcc/gcc/testsuite/gcc.dg/vect/vect-align-2.c 
> gcc_tg.o -ftree-vectorize -fno-vect-cost-model -mcpu=ultrasparc -mvis 
> -O2 -fdump-tree-vect-details -DSTACK_SIZE=2048 -fno-show-column 
> -B/home/joel/work-gnat/svn/bsp-install/sparc-rtems4.9/sis/lib/ -specs 
> bsp_specs -qrtems -mcpu=cypress 
> /home/joel/work-gnat/svn/b-gcc1-sparc/rtems_gcc_main.o -Wl,-wrap,exit 
> -Wl,-wrap,_exit -Wl,-wrap,main -Wl,-wrap,abort -lm -o 
> ./vect-align-2.exe (timeout = 300)
> PASS: gcc.dg/vect/vect-align-2.c (test for excess errors)
> Unexpected trap (0x 2) at address 0x020012B8^M
> illegal instruction^M
> FAIL: gcc.dg/vect/vect-align-2.c execution test

This is not-guarded runtime test. The problem is fixed by the attached 
patch.

2008-03-13  Uros Bizjak  <ubizjak@gmail.com>

        * gcc.dg/vect/vect-align-2.c: Remove dg-do run directive.
        (main): Call check_vect.

Tested on x86_64-pc-linux-gnu, committed to mainline.

Uros.

Index: vect-align-2.c
===================================================================
--- vect-align-2.c      (revision 133190)
+++ vect-align-2.c      (working copy)
@@ -1,5 +1,4 @@
 /* { dg-require-effective-target vect_int } */
-/* { dg-do run } */
 
 #include <stdlib.h>
 #include <stdarg.h>
@@ -36,6 +35,8 @@
 {
   struct foo  *fp = (struct foo *) malloc (2*sizeof (struct foo));
 
+  check_vect ();
+
   fbar(fp);
   return 0;
 }

Re: Test Harness and SPARC VIS Instructions

[Joel Sherrill]

Uros Bizjak wrote:
> Hello!
>
>   
>> This one looks like another test slipping another unsupported
>> instruction by.
>>
>> 0x020012b8 <fbar+40>: bne,pn %icc, 0x200138c <fbar+252>
>>
>> Is this UltraSPARC and not V7?  Do we need two bad instructions
>> in the test case?
>>
>> Executing on host: /home/joel/work-gnat/svn/b-gcc1-sparc/gcc/xgcc
>> -B/home/joel/work-gnat/svn/b-gcc1-sparc/gcc/
>> /home/joel/work-gnat/svn/gcc/gcc/testsuite/gcc.dg/vect/vect-align-2.c
>> gcc_tg.o -ftree-vectorize -fno-vect-cost-model -mcpu=ultrasparc -mvis
>> -O2 -fdump-tree-vect-details -DSTACK_SIZE=2048 -fno-show-column
>> -B/home/joel/work-gnat/svn/bsp-install/sparc-rtems4.9/sis/lib/ -specs
>> bsp_specs -qrtems -mcpu=cypress
>> /home/joel/work-gnat/svn/b-gcc1-sparc/rtems_gcc_main.o -Wl,-wrap,exit
>> -Wl,-wrap,_exit -Wl,-wrap,main -Wl,-wrap,abort -lm -o
>> ./vect-align-2.exe (timeout = 300)
>> PASS: gcc.dg/vect/vect-align-2.c (test for excess errors)
>> Unexpected trap (0x 2) at address 0x020012B8^M
>> illegal instruction^M
>> FAIL: gcc.dg/vect/vect-align-2.c execution test
>>     
>
> This is not-guarded runtime test. The problem is fixed by the attached
> patch.
>
>   
Confirmed in my overnight run.  See


It now looks like the scan-tree-dump-times tests are the next
easy group that isn't supported that needs to be marked as
not supported.  I didn't see anything obv

FAIL: gcc.dg/vect/pr33804.c scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/pr33804.c scan-tree-dump-times vect "vectorizing stmts using SLP" 1
FAIL: gcc.dg/vect/pr33953.c scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/pr33953.c scan-tree-dump-times vect "vectorizing stmts using SLP" 1

I assume these fail because we don't dump files from the target.
How do you indicate these are not supported?
> 2008-03-13  Uros Bizjak  <ubizjak@gmail.com>
>
>         * gcc.dg/vect/vect-align-2.c: Remove dg-do run directive.
>         (main): Call check_vect.
>
> Tested on x86_64-pc-linux-gnu, committed to mainline.
>
> Uros.
>
> Index: vect-align-2.c
> ===================================================================
> --- vect-align-2.c      (revision 133190)
> +++ vect-align-2.c      (working copy)
> @@ -1,5 +1,4 @@
>  /* { dg-require-effective-target vect_int } */
> -/* { dg-do run } */
>
>  #include <stdlib.h>
>  #include <stdarg.h>
> @@ -36,6 +35,8 @@
>  {
>    struct foo  *fp = (struct foo *) malloc (2*sizeof (struct foo));
>
> +  check_vect ();
> +
>    fbar(fp);
>    return 0;
>  }
>
>   


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
   Support Available             (256) 722-9985

Re: Test Harness and SPARC VIS Instructions

[Uros Bizjak]

On Fri, Mar 14, 2008 at 3:45 PM, Joel Sherrill
<joel.sherrill@oarcorp.com> wrote:

>  It now looks like the scan-tree-dump-times tests are the next
>  easy group that isn't supported that needs to be marked as
>  not supported.  I didn't see anything obv
>
>  FAIL: gcc.dg/vect/pr33804.c scan-tree-dump-times vect "vectorized 1 loops" 1
>  FAIL: gcc.dg/vect/pr33804.c scan-tree-dump-times vect "vectorizing stmts using SLP" 1
>  FAIL: gcc.dg/vect/pr33953.c scan-tree-dump-times vect "vectorized 1 loops" 1
>  FAIL: gcc.dg/vect/pr33953.c scan-tree-dump-times vect "vectorizing stmts using SLP" 1
>
>  I assume these fail because we don't dump files from the target.

No, these dumps are produced by the compiler, this test is not
executable test. It checks for some feature, and the failure means
that this feature is not supported, or was not triggered for some
reason. There are many check_effective_target_vect_<whatever>
procedures in testsuite/lib/target-supports.exp, and depending on what
your target supports, you should add the target to the correct ones.

>  How do you indicate these are not supported?

See above.

Uros.